[Tooling] Fix handling of empty release notes #21565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
approved these changes
Jan 7, 2025
fastlane/lanes/localization.rb
Outdated
| File.write(File.join(changelog_dir, 'default.txt'), '') | ||
| end | ||
| # Skip downloading release notes translations since the source is empty | ||
| files.delete("release_note_#{version_suffix}") |
There was a problem hiding this comment.
Reading this made me think at first that this was deleting a file with this name. Took me a minute to realize this was instead just removing the entry with that key from the files Hash instead.
Wouldn't it be more readable to do the check first, and only assign the value of files for that key (on line 201) if not empty?
In other words, write this block of code as:
if !File.exist?(…) || File.read(…).strip.empty?
# Clear release notes if the source file is empty
# …
else
# Make sure to also download the release notes translations (given we had non-empty original copy)
files["release_note_#{version_suffix}"] = { … }
endThere was a problem hiding this comment.
Good suggestion 👍 Updated on b590c80
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21565-b590c80 | |
| Commit | b590c80 | |
| Direct Download | jetpack-prototype-build-pr21565-b590c80.apk |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21565-b590c80 | |
| Commit | b590c80 | |
| Direct Download | wordpress-prototype-build-pr21565-b590c80.apk |
|
AliSoftware
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: p1733408151597889-slack-CC7L49W13
The main change is to better handle in the lane
download_metadata_stringsthe scenario when the source release notes files (WordPress/metadata/release_notes.txtorWordPress/jetpack_metadata/release_notes.txt) are empty, clearing the localized files used by Fastlane (fastlane/metadata/android/*/changelogs/default.txtorfastlane/jetpack_metadata/android/*/changelogs/default.txt).Additionally, I've also updated the lane
download_metadata_stringslane to use keywords syntax for parameters.To Test:
You can run the
download_metadata_stringslane using the command below (avoiding commiting/pushing) to make sure thedefault.txtfiles are cleared when the source notesrelease_notes.txtare empty. Whenrelease_notes.txthas content, thedefault.txtfiles should be fetched from GlotPress using the specifiedversion.bundle exec fastlane download_metadata_strings version:25.2 skip_commit:true