Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalStateException in domain registration fragment #21566

Merged

Conversation

nbradbury
Copy link
Contributor

Fixes #21563 - Note that this targets 25.6

In trunk follow these steps to reproduce the crash:

  • From the My Site tab, tap to change sites
  • Choose Add a site
  • Choose Create WordPress.com site
  • Skip choosing a topic or theme
  • When you get to Choose a domain, search for a domain ("Test" works fine)
  • Scroll down then tap the Search button on the soft keyboard
  • Boom!

Then pull this branch, follow the same steps, and notice no Boom!

@nbradbury nbradbury added this to the 25.6 ❄️ milestone Jan 7, 2025
@nbradbury nbradbury marked this pull request as ready for review January 7, 2025 20:54
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 7, 2025

1 Warning
⚠️ This PR is assigned to the milestone 25.6 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link

sonarqubecloud bot commented Jan 7, 2025

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21566-0d9fafa
Commit0d9fafa
Direct Downloadjetpack-prototype-build-pr21566-0d9fafa.apk
Note: Google Login is not supported on these builds.

@nbradbury nbradbury changed the base branch from trunk to release/25.6 January 7, 2025 21:11
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21566-0d9fafa
Commit0d9fafa
Direct Downloadwordpress-prototype-build-pr21566-0d9fafa.apk
Note: Google Login is not supported on these builds.

@tiagomar tiagomar self-requested a review January 8, 2025 02:15
Copy link
Contributor

@tiagomar tiagomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to fix the crash. I wasn't able to reproduce it in this build.

I concentrated my testing around Focus and covered the following scenarios:

  • Screen rotation
  • Split screen
  • Sending the app to background
  • Locking the screen
  • Tapping other elements
  • Navigating to "Help" and "Choose a theme" screens
  • Different text input types like autocomplete, talk-to-text and handwriting
  • Tablet + external keyboard

I also checked the other domains search entry points just in case (they're all quite different) and couldn't reproduce even with the 25.5.

Devices:

  • Pixel 8 Pro (Android 14)
  • Samsung Galaxy Tab S9 Ultra (Android 14)
  • Samsung Galaxy Note 20 (Android 12)

@nbradbury nbradbury merged commit 1ac190b into release/25.6 Jan 8, 2025
28 checks passed
@nbradbury nbradbury deleted the issue/21563-illegal-state-in-domain-search-2.5.6 branch January 8, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalStateException: focus search returned a view that wasn't able to take focus!
4 participants