-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IllegalStateException in domain registration fragment #21566
Fix IllegalStateException in domain registration fragment #21566
Conversation
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems to fix the crash. I wasn't able to reproduce it in this build.
I concentrated my testing around Focus and covered the following scenarios:
- Screen rotation
- Split screen
- Sending the app to background
- Locking the screen
- Tapping other elements
- Navigating to "Help" and "Choose a theme" screens
- Different text input types like autocomplete, talk-to-text and handwriting
- Tablet + external keyboard
I also checked the other domains search entry points just in case (they're all quite different) and couldn't reproduce even with the 25.5.
Devices:
- Pixel 8 Pro (Android 14)
- Samsung Galaxy Tab S9 Ultra (Android 14)
- Samsung Galaxy Note 20 (Android 12)
Fixes #21563 - Note that this targets 25.6
In
trunk
follow these steps to reproduce the crash:Then pull this branch, follow the same steps, and notice no Boom!