-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Check if email verified before allowing to update avatar #21568
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdamGrzybkowski This looks good and I'll approve it. I left a comment about the placement of the new string resource, but it's not a big deal at all. I'll leave it to you whether to make the change, and you can merge when ready.
Quality Gate passedIssues Measures |
There was a backend fix applied at Gravatar to disallow using authenticated endpoints with account that hasn't verified the email. Using authenticated endpoint creates a Gravatar profile, but this shouldn't happen if email is not verified.
This means that before uploading a photo (via REST API or QuickEditor) we need to make sure the email is verified. If not, a proper message should be shown to the user.
This is the corresponding iOS PR. The copy for the message matches it as well.
Here's how it looks:
To Test:
me
sectiongravatar_quick_editor
feature flag to test the old flow, but the email verification check is the same so if the above works, this should too.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):