Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GutenbergKit history navigation #21570

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 8, 2025

Enable navigating forwards and backwards in the editor history.

Related:

To Test:

See wordpress-mobile/GutenbergKit#55.

Regression Notes

  1. Potential unintended areas of impact
    None likely, given the changes are scoped to a single editor.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A.
  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Allow button interactivity when undo/redo actions are available.
Enable stepping forwards and backwards through the editor history.
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 8, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 8, 2025

Project dependencies changes

The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath):

list
Upgraded Dependencies
org.wordpress.gutenbergkit:android:55-a490cd3d2d70ad4bba501655f83fdc42b404d502, (changed from v0.0.3)
tree
 +--- project :libs:editor
-|    \--- org.wordpress.gutenbergkit:android:v0.0.3
+|    \--- org.wordpress.gutenbergkit:android:55-a490cd3d2d70ad4bba501655f83fdc42b404d502
-\--- org.wordpress.gutenbergkit:android:v0.0.3 (*)
+\--- org.wordpress.gutenbergkit:android:55-a490cd3d2d70ad4bba501655f83fdc42b404d502 (*)

Copy link

sonarqubecloud bot commented Jan 8, 2025

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21570-ecc0f33
Commitecc0f33
Direct Downloadjetpack-prototype-build-pr21570-ecc0f33.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21570-ecc0f33
Commitecc0f33
Direct Downloadwordpress-prototype-build-pr21570-ecc0f33.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.48%. Comparing base (dd12e2f) to head (ecc0f33).
Report is 12 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21570   +/-   ##
=======================================
  Coverage   39.48%   39.48%           
=======================================
  Files        2117     2117           
  Lines       99464    99464           
  Branches    15296    15296           
=======================================
  Hits        39269    39269           
  Misses      56714    56714           
  Partials     3481     3481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcalhoun dcalhoun marked this pull request as ready for review January 9, 2025 15:29
@dcalhoun dcalhoun requested a review from nbradbury January 9, 2025 15:31
@nbradbury nbradbury self-assigned this Jan 9, 2025
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :shipit:

@nbradbury nbradbury merged commit 4798818 into trunk Jan 9, 2025
24 checks passed
@nbradbury nbradbury deleted the feat/gutenberg-kit-history-navigation branch January 9, 2025 19:50
@dcalhoun
Copy link
Member Author

dcalhoun commented Jan 9, 2025

Thank you for the review, @nbradbury. 🙇🏻‍♂️

For future reference, before merging this type of WordPress-Android PR integrating GutenbergKit updates, I typically merge the GutenbergKit PR first and then update this PR to reference the merge commit. This avoids WordPress-Android referencing an orphaned commit. The value of this practice is debatable, but it's a practice I continue from past team guides nonetheless.

It's not a significant issue that we did not do that here, merely sharing for awareness.

@nbradbury
Copy link
Contributor

For future reference, before merging this type of WordPress-Android PR integrating GutenbergKit updates, I typically merge the GutenbergKit PR first and then update this PR to reference the merge commit. This avoids WordPress-Android referencing an orphaned commit. The value of this practice is debatable, but it's a practice I continue from past team guides nonetheless.

A fair point. Perhaps we should add the "Do not merge" label and remove it once the PR is truly ready to merge?

@dcalhoun
Copy link
Member Author

dcalhoun commented Jan 9, 2025

Perhaps we should add the "Do not merge" label and remove it once the PR is truly ready to merge?

Yeah, I can try to do so if it is helpful.

Part of the issue is that I, at times, struggle to remember the merging practices of a given repository I touch, an unfortunate side effect of diverging practices across our various repositories. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants