-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GutenbergKit history navigation #21570
Conversation
Allow button interactivity when undo/redo actions are available.
Enable stepping forwards and backwards through the editor history.
Generated by 🚫 Danger |
Project dependencies changesThe following changes in project dependencies were detected (configuration list
tree +--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:v0.0.3
+| \--- org.wordpress.gutenbergkit:android:55-a490cd3d2d70ad4bba501655f83fdc42b404d502
-\--- org.wordpress.gutenbergkit:android:v0.0.3 (*)
+\--- org.wordpress.gutenbergkit:android:55-a490cd3d2d70ad4bba501655f83fdc42b404d502 (*) |
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21570 +/- ##
=======================================
Coverage 39.48% 39.48%
=======================================
Files 2117 2117
Lines 99464 99464
Branches 15296 15296
=======================================
Hits 39269 39269
Misses 56714 56714
Partials 3481 3481 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thank you for the review, @nbradbury. 🙇🏻♂️ For future reference, before merging this type of WordPress-Android PR integrating GutenbergKit updates, I typically merge the GutenbergKit PR first and then update this PR to reference the merge commit. This avoids WordPress-Android referencing an orphaned commit. The value of this practice is debatable, but it's a practice I continue from past team guides nonetheless. It's not a significant issue that we did not do that here, merely sharing for awareness. |
A fair point. Perhaps we should add the "Do not merge" label and remove it once the PR is truly ready to merge? |
Yeah, I can try to do so if it is helpful. Part of the issue is that I, at times, struggle to remember the merging practices of a given repository I touch, an unfortunate side effect of diverging practices across our various repositories. 😅 |
Enable navigating forwards and backwards in the editor history.
Related:
To Test:
See wordpress-mobile/GutenbergKit#55.
Regression Notes
None likely, given the changes are scoped to a single editor.
N/A.
N/A.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):