Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WordPress.com for login redirect URL #21652

Open
wants to merge 1 commit into
base: release/25.6.1
Choose a base branch
from

Conversation

jkmassel
Copy link
Contributor

@jkmassel jkmassel commented Jan 31, 2025

Fixes a warning by the litter about custom scheme intents.

To test:

  • Try logging in using WP.com, it should work exactly the same

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 31, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21652-529d877
Commit529d877
Direct Downloadwordpress-prototype-build-pr21652-529d877.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 31, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21652-529d877
Commit529d877
Direct Downloadjetpack-prototype-build-pr21652-529d877.apk
Note: Google Login is not supported on these builds.

Comment on lines 120 to 127
<action android:name="android.intent.action.VIEW" />
<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />
<data
android:host="wpcom-authorize"
android:scheme="${magicLinkScheme}" />
</intent-filter>

Check warning

Code scanning / Android Lint

Application has custom scheme intent filters with missing autoVerify attributes Warning

Custom scheme intent filters should explicitly set the autoVerify attribute to true
@jkmassel jkmassel changed the base branch from trunk to release/25.6.1 January 31, 2025 20:48
@jkmassel jkmassel force-pushed the fix/security-issue-with-login branch from 0063e3f to 529d877 Compare January 31, 2025 20:50
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 31, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@jkmassel jkmassel marked this pull request as ready for review January 31, 2025 20:58
@jkmassel jkmassel added the Login label Feb 3, 2025
Copy link
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the WordPress app and encountered an issue where tapping login would always throw me to the home screen. I've provided a more detailed feedback about this in our internal Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants