Gravatar Image Issues #21672
Open
Gravatar Image Issues #21672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dPress-Android into trunk" This reverts commit 1cb521c, reversing changes made to a0b9df1.
Working on wordpress-mobile#21415 I pushed a fix for the Gravatar URL issue, but the image still doesn't load dynamically when using accountStore.account.email. However, it works fine when I pass my email directly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #21415
I pushed a fix for the Gravatar URL issue, but the image still doesn't load dynamically when using accountStore.account in meFragment.kt
I updated the code like this in meFragment.kt to load Gravatar based on email:
val email = defaultAccount.email
val avatarUrl = meGravatarLoader.constructGravatarUrl(email)
// Initially loading with null, then updating with the constructed URL
loadAvatar(null)
loadAvatar(avatarUrl)
However, it works fine when I pass my email directly in MeGravatarLoader.kt, I tested it by passing my email directly inside constructGravatarUrl, and it loads the image correctly
So it seems like accountStore.account.email is not returning the expected value.
Could you check my PR and help me debug this issue?
changes made file: