-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump androidx.paging:paging-runtime from 2.1.2 to 3.3.6 #21685
base: trunk
Are you sure you want to change the base?
build(deps): Bump androidx.paging:paging-runtime from 2.1.2 to 3.3.6 #21685
Conversation
Generated by 🚫 Danger |
Project dependencies changesThe following changes in project dependencies were detected (configuration list
tree++--- androidx.navigation:navigation-compose:2.8.7
+| +--- androidx.activity:activity-compose:1.8.0 -> 1.9.3
+| | +--- androidx.activity:activity-ktx:1.9.3
+| | | +--- androidx.activity:activity:1.9.3
+| | | | +--- androidx.core:core:1.13.0 -> 1.13.1
+| | | | | \--- androidx.lifecycle:lifecycle-runtime:2.6.2 -> 2.8.7
+| | | | | \--- androidx.lifecycle:lifecycle-runtime-android:2.8.7
+| | | | | +--- androidx.lifecycle:lifecycle-common:2.8.7
+| | | | | | \--- androidx.lifecycle:lifecycle-common-jvm:2.8.7
+| | | | | | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+| | | | | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+| | | | +--- androidx.lifecycle:lifecycle-viewmodel:2.6.1 -> 2.8.7
+| | | | | \--- androidx.lifecycle:lifecycle-viewmodel-android:2.8.7
+| | | | | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+| | | | \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.1 -> 2.8.7
+| | | | +--- androidx.lifecycle:lifecycle-livedata-core:2.8.7
+| | | | | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+| | | | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+| | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.6.1 -> 2.8.7
+| | | | \--- androidx.lifecycle:lifecycle-runtime-ktx-android:2.8.7
+| | | | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+| | | \--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.1 -> 2.8.7
+| | | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+| | \--- androidx.compose.ui:ui:1.0.1 -> 1.7.8
+| | \--- androidx.compose.ui:ui-android:1.7.8
+| | +--- androidx.compose.ui:ui-text:1.7.8
+| | | \--- androidx.compose.ui:ui-text-android:1.7.8
+| | | \--- androidx.emoji2:emoji2:1.2.0 -> 1.3.0
+| | | \--- androidx.lifecycle:lifecycle-process:2.4.1 -> 2.8.7
+| | | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+| | \--- androidx.lifecycle:lifecycle-runtime-compose:2.8.3 -> 2.8.7
+| | \--- androidx.lifecycle:lifecycle-runtime-compose-android:2.8.7
+| | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+| \--- androidx.lifecycle:lifecycle-viewmodel-compose:2.6.2 -> 2.8.7
+| \--- androidx.lifecycle:lifecycle-viewmodel-compose-android:2.8.7
+| \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
-\--- project :libs:fluxc
- \--- androidx.paging:paging-runtime:2.1.2
- +--- androidx.paging:paging-common:2.1.2
- | +--- androidx.annotation:annotation:1.0.0 -> 1.9.1 (*)
- | \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
- +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
- +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.8.7 (*)
- +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.8.7 (*)
- \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
++--- project :libs:analytics
+ \--- androidx.preference:preference:1.2.1
+ \--- androidx.appcompat:appcompat:1.1.0 -> 1.7.0
+ \--- androidx.fragment:fragment:1.5.4 -> 1.8.6
+ \--- androidx.loader:loader:1.0.0
+ \--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.8.7
+ +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.8.7
+ | \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
+ \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
++--- project :libs:editor
+| \--- com.automattic.tracks:crashlogging:5.1.0
+| \--- io.sentry:sentry-android -> 7.8.0
+| \--- io.sentry:sentry-android-core:7.8.0
+| \--- androidx.lifecycle:lifecycle-common-java8:2.2.0 -> 2.8.7
+| \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c)
++--- project :libs:fluxc
+| \--- androidx.paging:paging-runtime:3.3.6
+| +--- androidx.core:core-ktx:1.7.0 -> 1.13.1 (*)
+| +--- androidx.lifecycle:lifecycle-livedata-ktx:2.4.0 -> 2.8.7
+| | +--- androidx.lifecycle:lifecycle-livedata:2.8.7 (*)
+| | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.8.7 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
+| | +--- androidx.lifecycle:lifecycle-common:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-common-java8:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-livedata:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-livedata-core:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-livedata-core-ktx:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-process:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-runtime:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-runtime-compose:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-service:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-viewmodel:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-viewmodel-compose:2.8.7 (c)
+| | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.8.7 (c)
+| | \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.8.7 (c)
+| +--- androidx.lifecycle:lifecycle-runtime-ktx:2.4.0 -> 2.8.7 (*)
+| +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.0 -> 2.8.7 (*)
+| +--- androidx.paging:paging-common:3.3.6
+| | \--- androidx.paging:paging-common-android:3.3.6
+| | +--- androidx.annotation:annotation:1.8.1 -> 1.9.1 (*)
+| | +--- androidx.arch.core:core-common:2.2.0 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.7.3 -> 1.8.1 (*)
+| | +--- androidx.paging:paging-common-ktx:3.3.6 (c)
+| | \--- androidx.paging:paging-runtime:3.3.6 (c)
+| +--- androidx.paging:paging-common-ktx:3.3.6
+| | +--- androidx.paging:paging-common:3.3.6 (*)
+| | +--- androidx.paging:paging-common:3.3.6 (c)
+| | \--- androidx.paging:paging-runtime:3.3.6 (c)
+| +--- androidx.recyclerview:recyclerview:1.2.1 -> 1.3.2 (*)
+| +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
+| +--- androidx.paging:paging-common:3.3.6 (c)
+| \--- androidx.paging:paging-common-ktx:3.3.6 (c)
+\--- androidx.work:work-runtime:2.9.1
+ \--- androidx.lifecycle:lifecycle-service:2.5.1 -> 2.8.7
+ \--- androidx.lifecycle:lifecycle-livedata-ktx:2.8.7 (c) |
Bumps androidx.paging:paging-runtime from 2.1.2 to 3.3.6. --- updated-dependencies: - dependency-name: androidx.paging:paging-runtime dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
6e7093a
to
4538089
Compare
|
@oguzkocer @ParaskP7 I started updating the app to handle the changes in the paging runtime, most notably the switch from I'm wondering if this should be a task for infra, since you both worked on this in the past? |
Thanks for the ping @nbradbury ! 👍
I actually haven't worked much on this, it was implemented prior me joining Automattic. Quickly looking at the files you touched already, I only fixed a couple of static analysis issues here-and-there, so I am not sure about the actual effort here (without looking at it in a bit more depth). 🤔 Having said that, please feel free to open an Apps Infra request (dnsEh-p2), using the |
I am not sure if this is the same dependency, but at some point a couple years ago, some folks tried to update the paging library we are using for I don't know what happened after that, but thought I'd share this tidbit in case it's helpful. |
@oguzkocer This update does impact our post list, and what you describe is exactly what I'm seeing. I'm used to Google library updates requiring changes, but the number of changes required by this paging library update are still surprising to me. I think for now we'll have to punt on this (again) but at some point I assume we'll have no choice but to do the work to update the paging library. |
@nbradbury Since |
Bumps androidx.paging:paging-runtime from 2.1.2 to 3.3.6.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)