This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
[Bug] Add null check if response is null. #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfano
suggested changes
Jun 3, 2024
There was a problem hiding this comment.
May I suggest a different approach? If the response is null, onResponse() in the listener of fetchRevisions() can return BaseNetworkError(INVALID_RESPONSE). This way, the user can understand that there is an error instead of seeing an empty revision list.
You can see a similar solution in fetchSites() method.
|
Very useful @irfano . Thank you for pointing out a good error. It wasn't obvious in the file, at least that I could see. The base error case is a nice compromise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
What
This PR fixes a bug where fetching the revision history of a post can possibly be null. I'm not clear on how it's possible. But forced a null
revisionsResponseToRevisionsModeland can reproduce the crash. The simplest solution is to null check. Outside of that, I could not reproduce the crash organically.Test