Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Move Danger to GitHub Actions #22276

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Dec 22, 2023

This PR experiments moving the current Buildkite step setup to GitHub Actions (discussion on paaHJt-5Qn-p2).

Running on Buildkite is still an option, but it would require a GitHub action (or an intermediate server) to forward to Buildkite Pull Request Events such as "labeled", "unlabeled", "milestoned" and so on. This was implemented as a prototype on woocommerce/woocommerce-android#10385.

If we find problems using GitHub Actions, we can always revert this change and go back to Buildkite, as the setup works in general (just not as fast and as simple as GHA alone).

How to test

Make sure CI is green and Danger runs on labels/milestones/reviewers changes as well as on code changes.

@iangmaia iangmaia force-pushed the iangmaia/move-danger-to-gha branch from b737c66 to 666bc50 Compare December 22, 2023 18:57
@iangmaia iangmaia force-pushed the iangmaia/move-danger-to-gha branch from 666bc50 to 561ca98 Compare December 22, 2023 19:03
@iangmaia iangmaia added Tooling Build, Release, and Validation Tools and removed Tooling Build, Release, and Validation Tools labels Dec 22, 2023
@iangmaia iangmaia force-pushed the iangmaia/move-danger-to-gha branch 3 times, most recently from b7b077a to 87427eb Compare December 22, 2023 19:23
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 22, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22276-5aa18cf
Version24.0
Bundle IDorg.wordpress.alpha
Commit5aa18cf
App Center BuildWPiOS - One-Offs #8424
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 22, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22276-5aa18cf
Version24.0
Bundle IDcom.jetpack.alpha
Commit5aa18cf
App Center Buildjetpack-installable-builds #7447
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@iangmaia iangmaia added Tooling Build, Release, and Validation Tools [Status] DO NOT MERGE labels Dec 22, 2023
@iangmaia iangmaia self-assigned this Jan 4, 2024
@mokagio
Copy link
Contributor

mokagio commented Jan 8, 2024

Hey @iangmaia 👋 You might notice a merge trunk commit here from me. That is to bring this branch up to date with the latest CI changes on trunk and ensure everything works on the new Xcode 15.1 CI stack.

Don't hesitate to ping me if there's any trouble.

@iangmaia iangmaia force-pushed the iangmaia/move-danger-to-gha branch 2 times, most recently from 09611d7 to 78381e9 Compare January 9, 2024 12:00
@iangmaia iangmaia marked this pull request as ready for review January 9, 2024 15:03
@iangmaia iangmaia force-pushed the iangmaia/move-danger-to-gha branch 2 times, most recently from 3b5ef9b to 92f9ac5 Compare January 9, 2024 15:27
@iangmaia iangmaia requested a review from a team January 9, 2024 15:35
@iangmaia iangmaia force-pushed the iangmaia/move-danger-to-gha branch from 92f9ac5 to 5aa18cf Compare January 11, 2024 16:42
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@iangmaia iangmaia merged commit cd11c75 into trunk Jan 12, 2024
22 checks passed
@iangmaia iangmaia deleted the iangmaia/move-danger-to-gha branch January 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants