-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Move Danger to GitHub Actions #22276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
from
December 22, 2023 18:57
b737c66
to
666bc50
Compare
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
from
December 22, 2023 19:03
666bc50
to
561ca98
Compare
iangmaia
added
Tooling
Build, Release, and Validation Tools
and removed
Tooling
Build, Release, and Validation Tools
labels
Dec 22, 2023
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
3 times, most recently
from
December 22, 2023 19:23
b7b077a
to
87427eb
Compare
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
iangmaia
added
Tooling
Build, Release, and Validation Tools
[Status] DO NOT MERGE
labels
Dec 22, 2023
Hey @iangmaia 👋 You might notice a merge Don't hesitate to ping me if there's any trouble. |
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
2 times, most recently
from
January 9, 2024 12:00
09611d7
to
78381e9
Compare
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
2 times, most recently
from
January 9, 2024 15:27
3b5ef9b
to
92f9ac5
Compare
iangmaia
force-pushed
the
iangmaia/move-danger-to-gha
branch
from
January 11, 2024 16:42
92f9ac5
to
5aa18cf
Compare
Generated by 🚫 Danger |
AliSoftware
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR experiments moving the current Buildkite step setup to GitHub Actions (discussion on paaHJt-5Qn-p2).
Running on Buildkite is still an option, but it would require a GitHub action (or an intermediate server) to forward to Buildkite Pull Request Events such as "labeled", "unlabeled", "milestoned" and so on. This was implemented as a prototype on woocommerce/woocommerce-android#10385.
If we find problems using GitHub Actions, we can always revert this change and go back to Buildkite, as the setup works in general (just not as fast and as simple as GHA alone).
How to test
Make sure CI is green and Danger runs on labels/milestones/reviewers changes as well as on code changes.