Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark mode in navigation bar when presenting DomainSelection from SiteDomains #22391

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Jan 15, 2024

Fixes #22378

Use UINavigationController instead LightNavigationController.

To test:

  1. Menu
  2. Site Domains
  3. Add Domain
  4. Switch to dark mode
  5. Confirm navigation bar is dark
Simulator.Screen.Recording.-.iPhone.15.-.2024-01-15.at.13.47.28.mp4

Regression Notes

  1. Potential unintended areas of impact

None

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

3 What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@staskus staskus added this to the 24.1 milestone Jan 15, 2024
@staskus staskus requested a review from salimbraksa January 15, 2024 13:53
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 15, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22391-ded9f8d
Version24.0
Bundle IDorg.wordpress.alpha
Commitded9f8d
App Center BuildWPiOS - One-Offs #8446
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 15, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22391-ded9f8d
Version24.0
Bundle IDcom.jetpack.alpha
Commitded9f8d
App Center Buildjetpack-installable-builds #7469
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa
Copy link
Contributor

@staskus LGTM! 🚀

But I'm wondering this PR should target release/24.0?

DomainSelectionVC is wrapped into UIViewControllerRepresentable wrapper and used LightNavigationController which does not reflect dark mode chan presented from SwiftUI
@staskus staskus changed the base branch from trunk to release/24.0 January 15, 2024 20:23
@staskus staskus force-pushed the fix/site-domains-domains-view-doesnt-adapt-to-dark-mode-fully branch from 75f33b7 to ded9f8d Compare January 15, 2024 20:23
@staskus staskus modified the milestones: 24.1, 24.0 ❄️ Jan 15, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.0 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@staskus staskus merged commit 2bcad6e into release/24.0 Jan 15, 2024
2 of 16 checks passed
@staskus staskus deleted the fix/site-domains-domains-view-doesnt-adapt-to-dark-mode-fully branch January 15, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Domains: Domains view doesn't adapt to dark mode fully
4 participants