Reader: Apply equal heights between navigation and filter buttons #22544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22533
Fixes a case where the buttons' height are different as the display size changes. To fix this, I applied
frame(maxWidth: .infinity)
to all the children ofHStack
and appliedfixedSize
to the stack view. This will cause the stack view to grow up to the tallest child, and all the remaining children will expand to fill the gap, matching the height of the tallest child.Due to the contrast, it may appear that the buttons have a slight 1px height difference but that's probably an optical illusion! When measured through the visual debugger, they match:
To test
Regression Notes
Potential unintended areas of impact
Should be none.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the changes.
What automated tests I added (or what prevented me from doing so)
N/A.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: