Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Apply equal heights between navigation and filter buttons #22544

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Feb 5, 2024

Fixes #22533

Fixes a case where the buttons' height are different as the display size changes. To fix this, I applied frame(maxWidth: .infinity) to all the children of HStack and applied fixedSize to the stack view. This will cause the stack view to grow up to the tallest child, and all the remaining children will expand to fill the gap, matching the height of the tallest child.

Due to the contrast, it may appear that the buttons have a slight 1px height difference but that's probably an optical illusion! When measured through the visual debugger, they match:

Screenshot 2024-02-05 at 20 29 06

To test

  • Configure the phone or Simulator to use a larger display size
  • Launch the Jetpack app
  • Navigate to Reader and switch to Subscriptions
  • 🔎 Verify that the Reader navigation buttons have equal heights

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested the changes.

  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dvdchr dvdchr added this to the 24.2 ❄️ milestone Feb 5, 2024
@dvdchr dvdchr requested a review from wargcm February 5, 2024 15:33
@dvdchr dvdchr self-assigned this Feb 5, 2024
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.2 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22544-06a721e
Version24.2
Bundle IDorg.wordpress.alpha
Commit06a721e
App Center BuildWPiOS - One-Offs #8682
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22544-06a721e
Version24.2
Bundle IDcom.jetpack.alpha
Commit06a721e
App Center Buildjetpack-installable-builds #7710
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@wargcm wargcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@dvdchr dvdchr merged commit 1668cc9 into release/24.2 Feb 6, 2024
22 of 27 checks passed
@dvdchr dvdchr deleted the fix/reader-nav-buttons-height branch February 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: In a11y size, the navigation and filter buttons have different heights
4 participants