-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifications P1] Row UI Update #22545
[Notifications P1] Row UI Update #22545
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
This should be addressed in #22464 . I'll open a PR targeting this one. |
|
||
// configure separators view | ||
separatorsView.bottomColor = Style.separatorColor | ||
separatorsView.bottomVisible = true | ||
separatorsView.bottomVisible = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ListTableHeaderView
is used in the CommentsViewController
, so these changes will be applied to that screen as well, and I don't think we want that.
Feel free to revert the changes, I'll handle them in #22464.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll revert it.
@salimbraksa I haven't addressed the top alignment issue yet of a single row text. The rest is addressed. I'll re-request review once I do so. |
Fixes #22465
Description
Updates the styling of notifications cell to match the new designs by utilising Design System values.
Testing Steps
a. ✅ Title should not contain any bold/semibold
b. ✅ Title and description should be the same size
c. ✅ There should be no separators.
d. ✅ Each cell should contain maximum 4 lines of text. i.e. if title has 2 lines, description can only have 1 line. If title has 1 line, description can have maximum 2 lines.
Regression Notes
Potential unintended areas of impact
All UI changes that will be merged to the feature branch.
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: