Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications P1] Row UI Update #22545

Conversation

alpavanoglu
Copy link
Contributor

Fixes #22465

Description

Updates the styling of notifications cell to match the new designs by utilising Design System values.

Testing Steps

  1. Install & login to Jetpack App with an account that has any notifications.
  2. Navigate to Notifications Tab.
  3. Verify the rows match the designs:
    a. ✅ Title should not contain any bold/semibold
    b. ✅ Title and description should be the same size
    c. ✅ There should be no separators.
    d. ✅ Each cell should contain maximum 4 lines of text. i.e. if title has 2 lines, description can only have 1 line. If title has 1 line, description can have maximum 2 lines.

Regression Notes

  1. Potential unintended areas of impact
    All UI changes that will be merged to the feature branch.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22545-060d65a
Version24.2
Bundle IDcom.jetpack.alpha
Commit060d65a
App Center Buildjetpack-installable-builds #7721
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22545-060d65a
Version24.2
Bundle IDorg.wordpress.alpha
Commit060d65a
App Center BuildWPiOS - One-Offs #8694
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa
Copy link
Contributor

salimbraksa commented Feb 6, 2024

 Design Implementation

Comparing the Figma design with the implementation, I see the following differences:

  • Table view's background is white.
  • Section title fonts in the Design is 17pt, while in the app is 15pt
  • I feel there is more vertical space between the rows, can you double check?
  • See the last 2 notifications in the Implementation screenshot. The text is top aligned relative to the avatar, and it doesn't look good imo. So I suggest the following:
    • When the text height is smaller than the avatar's height, the text should be centrally aligned.
    • When the text height is larger than avatar's height, the avatar should be top aligned.

@salimbraksa
Copy link
Contributor

Section title fonts in the Design is 17pt, while in the app is 15pt

This should be addressed in #22464 . I'll open a PR targeting this one.


// configure separators view
separatorsView.bottomColor = Style.separatorColor
separatorsView.bottomVisible = true
separatorsView.bottomVisible = false
Copy link
Contributor

@salimbraksa salimbraksa Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ The ListTableHeaderView is used in the CommentsViewController, so these changes will be applied to that screen as well, and I don't think we want that.

Feel free to revert the changes, I'll handle them in #22464.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll revert it.

@alpavanoglu
Copy link
Contributor Author

@salimbraksa I haven't addressed the top alignment issue yet of a single row text. The rest is addressed. I'll re-request review once I do so.

@alpavanoglu alpavanoglu deleted the task/22465_notifications-row-ui-update branch February 13, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants