Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Apply workaround in gutenberg_post_install to address build failure #22658

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

fluiddot
Copy link
Contributor

This workaround solves the issue related to redefining clockid_t in the pod RCT-Folly when using a local bundle. The issue was introduced when upgrading the React Native version to 0.71.15 in this PR, which includes further information about the workaround.

To test:

  1. Check that you have the Gutenberg Mobile repository in a folder named gutenberg-mobile at the same level as the folder where WordPress-iOS repository is located.
  2. Quit Xcode if needed.
  3. Run rm -rf build && LOCAL_GUTENBERG=1 bundle exec pod install
  4. Open Xcode.
  5. Build the app and observe that no build failures are encountered.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

This workaround solves the issue related to redefining `clockid_t` in the pod `RCT-Folly` when using a local bundle.
@fluiddot fluiddot added Gutenberg Editing and display of Gutenberg blocks. Tooling Build, Release, and Validation Tools labels Feb 21, 2024
@fluiddot fluiddot added this to the 24.4 milestone Feb 21, 2024
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22658-29476af
Version24.2
Bundle IDcom.jetpack.alpha
Commit29476af
App Center Buildjetpack-installable-builds #7929
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22658-29476af
Version24.2
Bundle IDorg.wordpress.alpha
Commit29476af
App Center BuildWPiOS - One-Offs #8899
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@fluiddot fluiddot requested a review from dcalhoun February 21, 2024 15:19
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan succeeded for me. Thank you!

@fluiddot fluiddot enabled auto-merge February 21, 2024 15:24
@fluiddot fluiddot merged commit 983d13e into trunk Feb 21, 2024
21 checks passed
@fluiddot fluiddot deleted the rnmobile/fix/local-bundle-installation branch February 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants