-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alamofire to v5 #22707
Update Alamofire to v5 #22707
Conversation
AlamofireImage and AlamofireNetworkActivityIndicator are updated too.
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Jetpack with the reader and by checking that the https://giotestdotsite.wordpress.com/2024/02/27/tenor-post-with-alamofire-5/
+1 This Stack Overflow answer is useful in that it says "The deprecation message says: Provide a custom network activity UI in your app if desired." Also, |
Changes include:
I don't think we need AlamofireNetworkActivityIndicator, considering
UIApplication.networkActivityIndicatorVisible
has been deprecated and iOS doesn't even show a spinner in status bar any more (at least I can't find a way to make it).Test Instructions
You can test
AlamofireImage
changes by verifying images in Reader and Posts list can be displayed.Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
What are described in the "Test Instructions" section.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: N/A