Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert unowned to weak in ReaderCommentsFollowPresenter #22712

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Feb 27, 2024

Fixes #21730
Refs #22711

This converts the unowned property specifier for presentingViewController to weak, which addresses JETPACK-IOS-1796 and JETPACK-IOS-W96.

To test

  • Launch the Jetpack app
  • Navigate to any comment thread
  • Tap the "Follow" button on the top right
  • 🔎 Verify that you can Subscribe to post comments
  • Tap the notification bell icon to open the settings sheet, and toggle the in-app notification switch.
  • 🔎 Verify that you can subscribe/unsubscribe to in-app notifications
  • Tap "Unfollow Conversation"
  • 🔎 Verify that you can unfollow the thread successfully.

Additionally: Verify the Follow process from the Reader detail screen

Regression Notes

  1. Potential unintended areas of impact
    Should be none. No logic is altered with this change.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested the changes.

  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:
N/A

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dvdchr dvdchr added this to the 24.4 milestone Feb 27, 2024
@dvdchr dvdchr requested a review from wargcm February 27, 2024 17:27
@dvdchr dvdchr self-assigned this Feb 27, 2024
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22712-a8f85c9
Version24.3
Bundle IDorg.wordpress.alpha
Commita8f85c9
App Center BuildWPiOS - One-Offs #8998
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22712-a8f85c9
Version24.3
Bundle IDcom.jetpack.alpha
Commita8f85c9
App Center Buildjetpack-installable-builds #8036
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@wargcm wargcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@dvdchr dvdchr merged commit 87a3999 into trunk Feb 28, 2024
24 of 28 checks passed
@dvdchr dvdchr deleted the issue/21730-convert-unowned-to-weak branch February 28, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGABRT: actionButtonTapped > Fatal error: Attempted to read an unowned reference but the object was alrea...
3 participants