Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Traffic By Day tab from Stats dashboard card #22736

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Feb 29, 2024

Opens the older Day tab if Traffic is not enabled by its feature flag.

Thanks to the work in #22695, it was straightforward to handle both the scenario where the Traffic tab is enabled and when it's disabled.

Fixes #22716

To test:

  1. With the Traffic feature flag enabled, tap the Today's Stats dashboard card and expect to be taken to the Traffic tab with "By day" selected (even if you had previously "By month" or another period or tab selected).
  2. With the Traffic feature flag disabled, tap the Today's Stats dashboard card and expect to be taken to the Days tab (even if you had previously "Months" tab or another tab selected).

Regression Notes

  1. Potential unintended areas of impact

The functionality around opening Stats from the Today's Stats card.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

Navigation isn't suitable for unit testing and we only use UI tests for critical user flows

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • Portrait and landscape orientations.
  • iPhone and iPad.

Opens the older Day tab if Traffic is not enabled by its feature flag
@guarani guarani added this to the 24.4 milestone Feb 29, 2024
@guarani guarani requested a review from staskus February 29, 2024 20:18
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.4. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 29, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22736-3b2fbe5
Version24.3
Bundle IDorg.wordpress.alpha
Commit3b2fbe5
App Center BuildWPiOS - One-Offs #9043
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@staskus staskus enabled auto-merge March 1, 2024 07:42
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 1, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22736-3b2fbe5
Version24.3
Bundle IDcom.jetpack.alpha
Commit3b2fbe5
App Center Buildjetpack-installable-builds #8086
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@staskus staskus merged commit 020622f into trunk Mar 1, 2024
23 checks passed
@staskus staskus deleted the task/open-traffic-by-day-when-todays-stats-tapped branch March 1, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats Traffic: Open By Day Traffic tab from Today Dashboard Card
4 participants