-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enlarge Traffic date picker tap targets #22742
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The period drop-down feels much easier to tap for me.
Agree.
The left and right chevron buttons also do but might have room for improvement. I tried to increase their width, but they shifted too much after removing the padding. I'm keen to hear your thoughts on whether this should be improved.
It does feel better as well, I think the only other improvement would be to increase the chevron size itself. We can wait for feedback about that!
Fixes #22728
The goal here is to make the buttons in the date picker easier to tap while maintaining the same design and layout.
The date picker should still match the designs, while the invisible touch areas have increased in size.
To test
Regression Notes
The Traffic screen's date picker
Manual testing using the below testing checklist
This is a layout fix, not suitable for UI tests or unit tests
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: