Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include year in Traffic date picker #22766

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Mar 4, 2024

Adds the year to the date picker's display date to avoid confusion about which year is being displayed.

Fixes #22767

Screenshots

Before After

To test

  1. Open Stats
  2. Go to the Traffic tab
  3. Switch "By day" to different periods and notice the dates include the year (the exact formatting depends on the device locale):
    • By day: January 20, 2024
    • By week: Jan 15 - Jan 21, 2024
    • By year: January 2024

Regression Notes

  1. Potential unintended areas of impact

The Traffic tab is the only screen that might be affected

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing and existing unit tests.

  1. What automated tests I added (or what prevented me from doing so)

I added unit tests.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • iPhone and iPad.

Adds the year to the date picker's display date to avoid confusion about which year is being displayed.
@guarani guarani added this to the 24.4 ❄️ milestone Mar 4, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 4, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22766-29dd5c1
Version24.4
Bundle IDorg.wordpress.alpha
Commit29dd5c1
App Center BuildWPiOS - One-Offs #9070
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 4, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22766-29dd5c1
Version24.4
Bundle IDcom.jetpack.alpha
Commit29dd5c1
App Center Buildjetpack-installable-builds #8113
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@guarani guarani marked this pull request as ready for review March 4, 2024 22:03
@irfano irfano self-requested a review March 5, 2024 17:30
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The year is now shown with all granularities. I'm approving the PR. I have a minor comment. Feel free to merge after considering my comment. 👍🏻

@guarani guarani merged commit ebacfbc into release/24.4 Mar 6, 2024
29 checks passed
@guarani guarani deleted the bug/traffic-dates-include-year branch March 6, 2024 16:26
@guarani
Copy link
Contributor Author

guarani commented Mar 6, 2024

Hi @mokagio, I've merged this to the release branch to include it as a beta-fix.
Please let me know if you have any questions 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants