Reader: Restore the native scroll-to-top behavior #22771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #22770
With the new Reader design (internal ref: pcdRpT-506-p2), we unknowingly brought two scroll views on screen having both
scrollsToTop: true
, which breaks the native scroll-to-top behavior when tapping the status bar.The new scroll view comes from the
ReaderNavigationMenu
, which is written in SwiftUI. There's no direct access to thescrollsToTop
property, so we need traverse the generated views and update the property manually after the component is rendered.The native scroll-to-top in theory should trigger scrollViewDidScrollToTop(_:). In fact, this method is only triggered when scrolling to top from the status bar, but somehow it's not getting called (you had one job... 😅). So I depended on the existing
scrollViewDidScroll
method and added a little logic on theReaderTabView
that handles the scroll position calculations.I thought this would be a one-liner, but it turned out to be a fun little rabbit hole! 🐰 🪄
To test
Regression Notes
Potential unintended areas of impact
Should be none.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the changes.
What automated tests I added (or what prevented me from doing so)
N/A.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist:
Not applicable