Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Fix navigation button animation issues #22808

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Mar 11, 2024

Refs #22770

This addresses two issues:

  • When transitioning to "Subscriptions", the navigation button starts from a shifted position.
  • The filter chip buttons should animate from below the navigation button.

The first one is particularly tricky. It turned out that animating the label component of SwiftUI.Menu makes it twitch. The workaround is to separate the container capsule view and its contents with a ZStack container.

Before After
Filter chip animates from below the navigation button before-navbar after-navbar
Navigation button shouldn't twitch during transition
before-480.mov
after-480.mov

To test

  • Launch the Jetpack app and navigate to the Reader tab.
  • Change streams and observe the transition between chips, especially when transitioning to/from "Subscriptions".
  • 🔎 Verify that the transitions work as described.

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested the changes.

  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dvdchr dvdchr added this to the 24.5 milestone Mar 11, 2024
@dvdchr dvdchr requested a review from wargcm March 11, 2024 15:37
@dvdchr dvdchr self-assigned this Mar 11, 2024
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22808-98fb22f
Version24.4
Bundle IDcom.jetpack.alpha
Commit98fb22f
App Center Buildjetpack-installable-builds #8159
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22808-98fb22f
Version24.4
Bundle IDorg.wordpress.alpha
Commit98fb22f
App Center BuildWPiOS - One-Offs #9116
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@wargcm wargcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@dvdchr dvdchr merged commit da8d2d7 into trunk Mar 12, 2024
24 of 27 checks passed
@dvdchr dvdchr deleted the feature/reader-navbar-zindex branch March 12, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants