Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Hide "Tags" chip on the Reader subscriptions feed #22953

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

wargcm
Copy link
Contributor

@wargcm wargcm commented Apr 3, 2024

Fixes #22952

Description

Hides the "Tags" chip in the Reader Subscriptions feed.

Testing

To test:

  • Launch Jetpack and login
  • Enable the Reader tags feed feature flag
  • Navigate to the Reader Subscriptions feed
  • 🔎 Verify the "Tags" chip is no longer shown (Note: may need to restart after changing feature flag)

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wargcm wargcm added this to the 24.7 milestone Apr 3, 2024
@wargcm wargcm requested a review from dvdchr April 3, 2024 23:24
@wargcm wargcm self-assigned this Apr 3, 2024
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22953-1ad85c7
Version24.6
Bundle IDorg.wordpress.alpha
Commit1ad85c7
App Center BuildWPiOS - One-Offs #9373
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22953-1ad85c7
Version24.6
Bundle IDcom.jetpack.alpha
Commit1ad85c7
App Center Buildjetpack-installable-builds #8417
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Base automatically changed from issue/22950-tags-feed-feature-flag to trunk April 5, 2024 22:21
@wargcm wargcm merged commit 393ab0c into trunk Apr 5, 2024
25 of 30 checks passed
@wargcm wargcm deleted the issue/22952-remove-tags-chip branch April 5, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader: Remove tags chip from the subscriptions feed
3 participants