Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Add "Your Tags" feed menu item #22981

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

wargcm
Copy link
Contributor

@wargcm wargcm commented Apr 9, 2024

Fixes #22954

Description

  • Add the "Your Tags" feed (✅ feature flag)
  • Separate menu items into sections (❌ feature flag)
  • Update "Lists" feed icon (❌ feature flag)

Screenshots

Before After
Screenshot 2024-04-09 at 6 02 20 PM Screenshot 2024-04-09 at 5 57 54 PM

Testing

To test:

  • Use an account which has > 2 lists
  • Launch Jetpack and login
  • Enable the "Reader Tags Feed" feature flag (may require restart)
  • Navigate to Reader
  • Tap on the navigation menu button
  • 🔎 Verify there are dividers:
    • Before the "Saved" feed
    • Before the "Your Tags" feed
  • 🔎 Verify the "Lists" feed has an icon and matches the design
  • Tap on the "Your Tags" feed (Note: the feed doesn't do anything at this point, that will be a future PR)
  • 🔎 Verify 🔵 Tracked: reader_dropdown_menu_item_tapped <id: tags> is sent

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wargcm wargcm added this to the 24.7 milestone Apr 9, 2024
@wargcm wargcm requested a review from dvdchr April 9, 2024 22:44
@wargcm wargcm self-assigned this Apr 9, 2024
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22981-f9a648c
Version24.6
Bundle IDorg.wordpress.alpha
Commitf9a648c
App Center BuildWPiOS - One-Offs #9434
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22981-f9a648c
Version24.6
Bundle IDcom.jetpack.alpha
Commitf9a648c
App Center Buildjetpack-installable-builds #8477
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@wargcm wargcm merged commit 9fb2da7 into trunk Apr 10, 2024
24 of 29 checks passed
@wargcm wargcm deleted the issue/22954-add-tags-stream branch April 10, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reader: Add tags stream to dropdown list
3 participants