Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where the “Threads” icon was repeated #23968

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

jkmassel
Copy link
Contributor

See Zendesk 9258078

Fixes an issue where threads account would show up 3 times instead of 1 while publishing.

To test:

  • Connect a threads account on a Jetpack site
  • Write a post, press publish, check social settings

Before:

  • There would be 3 threads icons, and if you tapped into the social settings it would show the amount 3 times

After:

  • There is an appropriate number of icons and items in the list

Because the code didn't know about Threads, it was mis-mapping the data to what the UI expects. This is a bit of a hack because if we get a new social network we'll probably have the same problem? But that doesn't happen often enough for a big refactor, I'd rather just get this fixed for the user.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@jkmassel jkmassel requested review from crazytonyli and kean January 10, 2025 23:08
@jkmassel jkmassel self-assigned this Jan 10, 2025
@jkmassel jkmassel changed the base branch from trunk to release/25.6 January 10, 2025 23:08
@jkmassel jkmassel changed the base branch from release/25.6 to trunk January 10, 2025 23:08
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23968-f7644ac
Version25.6
Bundle IDorg.wordpress.alpha
Commitf7644ac
App Center BuildWPiOS - One-Offs #11333
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23968-f7644ac
Version25.6
Bundle IDcom.jetpack.alpha
Commitf7644ac
App Center Buildjetpack-installable-builds #10365
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants