Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing PostPost Buttons #9788

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Fixing PostPost Buttons #9788

merged 2 commits into from
Jul 18, 2018

Conversation

jleandroperez
Copy link
Contributor

Fixes #9786

cc @mindgraffiti (Thanks in advance!!)
cc @loremattei

Notes:

NUXSubmitButton was nuked. We're replacing it's references with FancyButton. The current PR looks slightly different as before:

  • Button Radius is different
  • The legacy NUXSubmitButton didn't have a drop shadow

I've filed this WordPressUI Issue to enhance FancyButton, so that we can replicate the exact same UI.

To test:

  1. Fresh install WPiOS
  2. Log into your dotcom account
  3. Publish a new post
  4. Press over the View button that shows up in the Post Notice

Verify that the PostPost UI looks as follows:

simulator screen shot - iphone se - 2018-07-17 at 14 18 06

@jleandroperez jleandroperez mentioned this pull request Jul 17, 2018
Open
@wpmobilebot
Copy link
Contributor

2 Warnings
⚠️ PR is missing at least one label.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@jleandroperez jleandroperez added this to the 10.5 ❄️ milestone Jul 17, 2018
@jleandroperez jleandroperez self-assigned this Jul 17, 2018
mindgraffiti
mindgraffiti approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @jleandroperez!

:shipit:

@jleandroperez
Copy link
Contributor Author

Thanks for the review Thuy!!

@jleandroperez jleandroperez merged commit 772cd6e into release/10.5 Jul 18, 2018
@jleandroperez jleandroperez deleted the issue/9786-fixing-post-post branch July 18, 2018 14:27
@loremattei loremattei mentioned this pull request Jul 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mindgraffiti mindgraffiti mindgraffiti approved these changes

Assignees

@jleandroperez jleandroperez

Labels
[Type] Bug
Projects
None yet
Milestone
10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@jleandroperez @wpmobilebot @mindgraffiti