-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Social Icons: Ensure inactive icons are visible with block-based themes #6302
[RNMobile] Social Icons: Ensure inactive icons are visible with block-based themes #6302
Conversation
…nd-dark-mode' of github.com:wordpress-mobile/gutenberg-mobile into version-toolkit/gutenberg/rnmobile/social-icon-background-dark-mode
Hey @SiobhyB 👋 Since we are updating how the social icons get rendered, we'd need to update the visual tests snapshots before merging this PR. |
…con-background-dark-mode
@geriux, thank you! I'm currently experiencing some issues running the UI tests but will update here when I've updated the snapshots. |
No problem! Let me know if I can help with those issues! |
…con-background-dark-mode
…con-background-dark-mode
@geriux, screenshots are updated now :) |
Thank you! It looks like this PR is not referencing the latest changes in Gutenberg Maybe it'd be easier to merge WordPress/gutenberg#55398 and update the Gutenberg reference with the merge commit in this PR. What do you think? |
Yes, of course, I've gone ahead to begin the merge waterfall now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tests passed correctly in CI 🚀 Nice work!
Related PRs
Description
This PR is generated by
version-toolkit
to downstream the changes forgutenberg
submodule.