Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Social Icons: Ensure inactive icons are visible with block-based themes #6302

Conversation

wpmobilebot
Copy link
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@SiobhyB SiobhyB requested review from geriux and dcalhoun October 19, 2023 22:03
@geriux
Copy link
Contributor

geriux commented Oct 23, 2023

Hey @SiobhyB 👋 Since we are updating how the social icons get rendered, we'd need to update the visual tests snapshots before merging this PR.

@derekblank derekblank modified the milestone: 1.107.0 (23.6) Oct 24, 2023
@SiobhyB
Copy link
Contributor

SiobhyB commented Oct 24, 2023

@geriux, thank you! I'm currently experiencing some issues running the UI tests but will update here when I've updated the snapshots.

@geriux
Copy link
Contributor

geriux commented Oct 24, 2023

@geriux, thank you! I'm currently experiencing some issues running the UI tests but will update here when I've updated the snapshots.

No problem! Let me know if I can help with those issues!

@SiobhyB
Copy link
Contributor

SiobhyB commented Oct 25, 2023

@geriux, screenshots are updated now :)

@geriux
Copy link
Contributor

geriux commented Oct 25, 2023

@geriux, screenshots are updated now :)

Thank you!

It looks like this PR is not referencing the latest changes in Gutenberg trunk where we made changes for Appium 2. Since this PR is up to date with Gutenberg Mobile's trunk it'd be ideal to sync them so we can run the full tests before merging.

Maybe it'd be easier to merge WordPress/gutenberg#55398 and update the Gutenberg reference with the merge commit in this PR. What do you think?

@SiobhyB
Copy link
Contributor

SiobhyB commented Oct 25, 2023

Maybe it'd be easier to merge WordPress/gutenberg#55398 and update the Gutenberg reference with the merge commit in this PR. What do you think?

Yes, of course, I've gone ahead to begin the merge waterfall now.

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests passed correctly in CI 🚀 Nice work!

@SiobhyB SiobhyB merged commit e68263a into trunk Oct 25, 2023
@SiobhyB SiobhyB deleted the version-toolkit/gutenberg/rnmobile/social-icon-background-dark-mode branch October 25, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants