Release 3.0.0 into trunk #334
Conversation
|
There are a couple of small TODO/FIXME in the codebase right now that would be worth addressing before doing this new major version. (One that comes to mind is changing the default value for the default branch to Maybe not everything that is currently deprecated is ready to be already removed (the localize_projects stuff should probably wait for next major after that to get removed given we haven't transitioned to the new actions in client apps yet) but probably some quick-win ones could be addressed still? |
We're getting ready to ship a new major version, 3.0.0, which is the best time to introduce this breaking change, as the `TODO` comment suggested. See also: #334 (comment)
…rameter Update `DEFAULT_GIT_BRANCH` from `develop` to `trunk`
|
Thanks for the I found four Going to remove deprecated actions next, while I'm at it. |
I also verified that this wasn't used in WordPress, WooCommerce, or Simplenote.
I verified that is not used in WordPress, WooCommerce, or Simplenote. Interestingly, neither is the suggested alternative, `ios_merge_strings_file`.
Currently only used in Simplenote Android, which is on pause. See https://github.com/Automattic/simplenote-android/blob/ca4c775cf62dd0f3178e50564d8d4a17d17408ef/fastlane/Fastfile#L199
…tead-of-reimplementing Remove custom check for CI in favor of using Fastlane's one
…oject`" This reverts commit fa390b6.
Remove deprecated, unused actions
There was a problem hiding this comment.
Just approved and merged #337 so we should now be good to go! 🎉
New version 3.0.0.
Be sure to create a GitHub Release and tag once this PR gets merged.
I'd like to release a new version so that we can use the
buildkite_trigger_buildaction in WordPress iOS and ditch CircleCI for releases, ideally starting in 19.2 🤞 ⏱️I haven't enabled auto-merge so I can merge, tag, push, and release once approved.