Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Ported LinkButton in Rust #546

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Conversation

mbilal234
Copy link
Contributor

Please check the rust implementation of the linkbutton.
The preview works fine on the workbench on my side.

Please review.

@mbilal234 mbilal234 changed the title RUST LinkButton Implementation library: Ported LinkButton in Rust Aug 29, 2023
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the comments are addressed, it looks good to me to merge

src/Library/demos/Link Button/code.rs Show resolved Hide resolved
src/Library/demos/Link Button/code.rs Outdated Show resolved Hide resolved
@Hofer-Julian
Copy link
Contributor

@mbilal234 could you please remove the separator demo from this PR?

@mbilal234
Copy link
Contributor Author

@mbilal234 could you please remove the separator demo from this PR?

Deleted

@sonnyp
Copy link
Contributor

sonnyp commented Aug 29, 2023

You can add yourself to contributors in about.js if you like in the next PR 👍

@Hofer-Julian Hofer-Julian merged commit edbc7a4 into workbenchdev:main Aug 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants