-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library: Ported ToggleButton
to RUST
#562
Merged
Hofer-Julian
merged 7 commits into
workbenchdev:main
from
onkarrai06:Workbench-ToggleButton
Aug 31, 2023
Merged
library: Ported ToggleButton
to RUST
#562
Hofer-Julian
merged 7 commits into
workbenchdev:main
from
onkarrai06:Workbench-ToggleButton
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hofer-Julian
requested changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the comments, it looks good
Co-authored-by: Hofer-Julian <[email protected]>
Co-authored-by: Hofer-Julian <[email protected]>
Updated, please check and let me know of any problem. |
saadulkh
reviewed
Aug 31, 2023
Hofer-Julian
approved these changes
Aug 31, 2023
Thank you for both of your suggestions and help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported ToggleButton to RUST via reference of JS implementation. Converted the dictionary in JS to a Hashmap and cloned it in order to avoid borrowing issues. Please check and let me know of any anomaly.