Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Ported ToggleButton to RUST #562

Merged
merged 7 commits into from
Aug 31, 2023

Conversation

onkarrai06
Copy link
Contributor

Ported ToggleButton to RUST via reference of JS implementation. Converted the dictionary in JS to a Hashmap and cloned it in order to avoid borrowing issues. Please check and let me know of any anomaly.

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments, it looks good

src/Library/demos/Toggle Button/code.rs Outdated Show resolved Hide resolved
src/Library/demos/Toggle Button/code.rs Outdated Show resolved Hide resolved
src/Library/demos/Toggle Button/code.rs Outdated Show resolved Hide resolved
@onkarrai06
Copy link
Contributor Author

Updated, please check and let me know of any problem.

@Hofer-Julian
Copy link
Contributor

I've removed the annotation and followed @saadulkh's helpful suggestion in 5cde951

@Hofer-Julian Hofer-Julian merged commit f8e4f60 into workbenchdev:main Aug 31, 2023
1 check passed
@onkarrai06
Copy link
Contributor Author

Thank you for both of your suggestions and help!

@onkarrai06 onkarrai06 deleted the Workbench-ToggleButton branch August 31, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants