Add typechecking for TypeScript

.gitmodules

@@ -7,3 +7,7 @@
 [submodule "blueprint-compiler"]
 	path = blueprint-compiler
 	url = https://gitlab.gnome.org/jwestman/blueprint-compiler.git
+[submodule "src/langs/typescript/template/gi-types"]
+	path = src/langs/typescript/template/gi-types
+	url = https://gitlab.gnome.org/BrainBlasted/gi-typescript-definitions.git
+	branch = nightly

src/common.js

@@ -128,14 +128,7 @@ export const languages = [
     document: null,
     default_file: "main.ts",
     index: 4,
-    language_server: [
-      "biome",
-      "lsp-proxy",
-      // src/meson.build installs biome.json there
-      GLib.getenv("FLATPAK_ID")
-        ? `--config-path=${pkg.pkgdatadir}`
-        : `--config-path=src/langs/typescript`,
-    ],
+    language_server: ["typescript-language-server", "--stdio"],
     formatting_options: {
       ...formatting_options,
       tabSize: 2,

src/langs/typescript/TypeScriptDocument.js

@@ -8,8 +8,8 @@ export class TypeScriptDocument extends Document {
     super(...args);
 
     this.lspc = setup({ document: this });
+    this.code_view.lspc = this.lspc;
   }
-
   async format() {
     // https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_formatting
     const text_edits = await this.lspc.request("textDocument/formatting", {
@@ -25,10 +25,6 @@ export class TypeScriptDocument extends Document {
       },
     });
 
-    // Biome doesn't support diff - it just returns one edit
-    // we don't want to loose the cursor position so we use this
-    const state = this.code_view.saveState();
     applyTextEdits(text_edits, this.buffer);
-    await this.code_view.restoreState(state);
   }
 }

src/langs/typescript/template/meson.build

@@ -1,3 +1,6 @@
-install_data(['types/ambient.d.ts', 'types/gi-module.d.ts', 'tsconfig.json'],
+install_data(['types/ambient.d.ts', 'tsconfig.json'],
              install_dir : join_paths(pkgdatadir, 'langs/typescript/template'),
              preserve_path: true)
+
+install_subdir('gi-types',
+             install_dir : join_paths(pkgdatadir, 'langs/typescript/template'))

src/langs/typescript/template/tsconfig.json

@@ -6,9 +6,11 @@
     // currently supported by the latest GJS
     "target": "ESNext",
     "outDir": "compiled_javascript",
+    "baseUrl": ".",
     "paths": {
-      "gi://*": ["./types/gi-module.d.ts"]
-    }
+      "*": ["*", "types/*"]
+    },
+    "skipLibCheck": true
   },
-  "include": ["main.ts", "types/ambient.d.ts", "types/gi-module.d.ts"]
+  "include": ["main.ts", "types/ambient.d.ts", "gi-types/gi.d.ts"]
 }

src/langs/typescript/typescript.js

@@ -1,7 +1,7 @@
 import Gio from "gi://Gio";
 
 import { createLSPClient } from "../../common.js";
-import { getLanguage, copy } from "../../util.js";
+import { copy, copyDirectory, ensureDir, getLanguage } from "../../util.js";
 import { isTypeScriptEnabled } from "../../Extensions/Extensions.js";
 
 export function setup({ document }) {
@@ -42,10 +42,10 @@ const typescript_template_dir = Gio.File.new_for_path(
 
 export async function setupTypeScriptProject(destination) {
   const types_destination = destination.get_child("types");
+  ensureDir(types_destination);
 
-  if (!types_destination.query_exists(null)) {
-    types_destination.make_directory_with_parents(null);
-  }
+  const gi_types_destination = destination.get_child("gi-types");
+  ensureDir(gi_types_destination);
 
   return Promise.all([
     copy(
@@ -54,11 +54,9 @@ export async function setupTypeScriptProject(destination) {
       types_destination,
       Gio.FileCopyFlags.NONE,
     ),
-    copy(
-      "types/gi-module.d.ts",
-      typescript_template_dir,
-      types_destination,
-      Gio.FileCopyFlags.NONE,
+    copyDirectory(
+      typescript_template_dir.get_child("gi-types"),
+      gi_types_destination,
     ),
     copy(
       "tsconfig.json",

src/lsp/LSPClient.js

@@ -299,7 +299,7 @@ export default class LSPClient {
       },
       position: {
         line: iter_cursor.get_line(),
-        character: iter_cursor.get_line_offset() - 1,
+        character: iter_cursor.get_line_offset(),
       },
     });