Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency for GOM demo #981

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Add dependency for GOM demo #981

merged 4 commits into from
Sep 5, 2024

Conversation

BharatAtbrat
Copy link
Contributor

@BharatAtbrat BharatAtbrat commented Aug 13, 2024

sonnyp
sonnyp previously requested changes Aug 13, 2024
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to a file in modules/gom.json and use the http archive
like other dependencies such as https://github.com/workbenchdev/Workbench/blob/main/build-aux/modules/libshumate.json

create gom.json for dependencies
remove redundant use in devel
@andyholmes andyholmes dismissed sonnyp’s stale review September 5, 2024 05:41

Requested changes have been made, so proceeding with merge.

@andyholmes andyholmes merged commit 154f5ea into main Sep 5, 2024
1 check passed
@andyholmes andyholmes deleted the gom_dep branch September 5, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants