336 open step card on timeline click

[ricardovdheijden]

#336

• When clicking on timeline item, the step card opens up when scrolling to that step card
• Makes the whole step card header clickable
• Applies round borders to codeblock

[changeset-bot]

⚠️ No Changeset found

Latest commit: c1e0c75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[DutchBen]

This functions isn't triggered when the item is expanded but it's actually expading it so a better namen would be expandStepListItem or doExpandStepListItem if you want to keep using verbs.

[ricardovdheijden]

The component "WFOStepList" exposes this function as a prop. Therefore, by convention, we should name it on..... (similar to onClick etc)

[ricardovdheijden]

renamed to onTrigger...

[mrijk]

Maybe assign stepListItems[previousIndex].step.status to a variable? instead of having it twice?

In general I stop reading code as soon as it involves array indices ;) This can almost always be abstracte away with higher-level libs like lodash (or whatever is the flavour of the day) to avoid of-by-one errors.

[ricardovdheijden]

Extracted a previousStep const.

About the array and indices: normally I would agree, but this code is temporary copied from our V1 app. It is waiting to be replaced by a new functionality in the backend to calculate the diff.