Convert createClient internals to a class
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthadley
commented
Nov 1, 2024
| #state: State; | ||
| #refreshTimer: ReturnType<typeof setTimeout> | undefined; | ||
|
|
||
| readonly #clientId: string; |
There was a problem hiding this comment.
Browser support for private methods in JavaScript itself is pretty good, but we also don't need to worry about it yet since our tsconfig targets es2020, which means the resulting code doesn't actually make use of this exact syntax yet.
But either way we should be getting pretty good runtime privacy (as opposed to only compile time via the TypeScript private), since the compiler generates pretty interesting code. Worth glancing through dist.
There was a problem hiding this comment.
I've been curious about browser support, but it's cool to see the polyfill code too.
dandorman
approved these changes
Nov 3, 2024
cmatheson
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class fulfills the same interface that the previous anonymous object returned by
createClientdid, so these should not be a breaking change.In the future, we may want to consider removing
createClientcompletely and have callers instantiateClientdirectly (or maybe call a factory/staticmethod likeClient.initialize).