Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable OpenTelemetry metrics and traces for Spanner client #280

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

SanjayVas
Copy link
Member

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas
Copy link
Member Author

Depends on #278

@SanjayVas SanjayVas force-pushed the sanjayvas-spanner-instrumentation branch from d8205ec to cf90b56 Compare October 1, 2024 20:25
@SanjayVas SanjayVas changed the title feat: Enable OpenTelemetry metrics for Spanner client feat: Enable OpenTelemetry metrics and traces for Spanner client Oct 1, 2024
@SanjayVas SanjayVas force-pushed the sanjayvas-spanner-instrumentation branch 3 times, most recently from 72cfa76 to f0c425b Compare October 1, 2024 22:56
Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Base automatically changed from sanjayvas-thread-pool-instrumentation to main October 2, 2024 16:15
@SanjayVas SanjayVas force-pushed the sanjayvas-spanner-instrumentation branch from f0c425b to 44b616d Compare October 2, 2024 16:16
@SanjayVas SanjayVas merged commit fc48fcc into main Oct 2, 2024
3 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-spanner-instrumentation branch October 2, 2024 22:27
@SanjayVas SanjayVas restored the sanjayvas-spanner-instrumentation branch October 3, 2024 17:56
@SanjayVas SanjayVas deleted the sanjayvas-spanner-instrumentation branch October 3, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants