-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update common-jvm for Postgres testing. #1169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 36 files reviewed, 3 unresolved discussions (waiting on @tristanvuong2021)
src/main/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/deploy/postgres/PostgresBackingStore.kt
line 39 at r1 (raw file):
* by the backing store and should not be used outside this backing store. * * TODO(@uakyol): Use R2DBC-based
CC @uakyol
src/main/kotlin/org/wfanet/measurement/reporting/service/internal/testing/v2/ReportingSetsServiceTest.kt
line 49 at r1 (raw file):
@RunWith(JUnit4::class) abstract class ReportingSetsServiceTest<T : ReportingSetsCoroutineImplBase> {
@tristanvuong2021 this test was failing for some reason when I switched to PostgresDatabaseProviderRule. My first attempt was to simplify the test cases using a sequential ID generator. That worked, so I didn't investigate further. I can share the failure details if you'd like to take a look.
src/test/kotlin/org/wfanet/measurement/eventdataprovider/privacybudgetmanagement/deploy/postgres/PostgresBackingStoreTest.kt
line 61 at r1 (raw file):
* PostgreSQL test container. * * TODO(@uakyol): Use [org.wfanet.measurement.common.db.r2dbc.postgres.testing.PostgresDatabaseProviderRule]
CC @uakyol
17d852d
to
e070784
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 35 of 36 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @SanjayVas)
src/test/kotlin/org/wfanet/measurement/reporting/deploy/postgres/PostgresReportingSetsServiceTest.kt
line 31 at r2 (raw file):
idGenerator: IdGenerator, ): PostgresReportingSetsService { val dbClient: PostgresDatabaseClient = databaseProvider.createDatabase()
nit: Noticed that this was renamed to dbClient, but the rest was kept as client.
c8c75a4
to
ab4944a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 34 of 36 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @SanjayVas and @tristanvuong2021)
ab4944a
to
f1960c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r4, all commit messages.
Reviewable status: 34 of 36 files reviewed, 3 unresolved discussions (waiting on @tristanvuong2021 and @YuhongWang-Amazon)
src/main/kotlin/org/wfanet/measurement/reporting/service/internal/testing/v2/ReportingSetsServiceTest.kt
line 49 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
@tristanvuong2021 this test was failing for some reason when I switched to PostgresDatabaseProviderRule. My first attempt was to simplify the test cases using a sequential ID generator. That worked, so I didn't investigate further. I can share the failure details if you'd like to take a look.
Actually the sequential ID generator wasn't even needed since this API now has user-specified IDs.
src/test/kotlin/org/wfanet/measurement/reporting/deploy/postgres/PostgresReportingSetsServiceTest.kt
line 31 at r2 (raw file):
Previously, tristanvuong2021 (Tristan Vuong) wrote…
nit: Noticed that this was renamed to dbClient, but the rest was kept as client.
Ah, it wasn't renamed but extracted to a new variable. I don't think the inconsistency here is a big issue (arguably client
everywhere else is a bit vague, but not worth going and renaming them all).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r4.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @tristanvuong2021 and @YuhongWang-Amazon)
f1960c4
to
0660055
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021 and @YuhongWang-Amazon)
0660055
to
1e94686
Compare
The unused AWS Kingdom schema and its associated test are deleted.
1e94686
to
efad2f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r6.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @tristanvuong2021 and @YuhongWang-Amazon)
The unused AWS Kingdom schema and its associated test are deleted.
The unused AWS Kingdom schema and its associated test are deleted.