Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cran feedback CU-8677zdwwa #62

Merged
merged 7 commits into from
Jun 22, 2023
Merged

Fix cran feedback CU-8677zdwwa #62

merged 7 commits into from
Jun 22, 2023

Conversation

randrescastaneda
Copy link
Collaborator

Related GitHub issues and pull requests

Summary

Hi @tonyfujs .

I fixed 4 out of the 6 items in #60 . The last items was converted into issue #61, so I'll take a look at it separately. However, the following item is not clear to me:

Please write about the structure of the output (class) and also what the output means. (If a function does not return a value, please document that too, e.g. \value{No return value, called for side effects} or similar)

I checked and removed unnecessary error classes, like "pipr_error", and also explained the class "pip_api" in the return field of the roxygen documentation of every function. However, I don't what else is needed. all the checks passed (see image below).

Best,

image

@randrescastaneda randrescastaneda changed the title 60 cran feedback Fix cran feedback CU-8677zdwwa May 10, 2023
@randrescastaneda
Copy link
Collaborator Author

Task linked: CU-8677zdwwa Fix CRAN submission feeback

@tonyfujs tonyfujs merged commit b9aac2f into DEV Jun 22, 2023
@tonyfujs tonyfujs deleted the 60_cran_feedback branch June 22, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants