Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV 1354: Delete usernames upon request #73

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

DEV 1354: Delete usernames upon request #73

wants to merge 20 commits into from

Conversation

Takaros999
Copy link
Contributor

@Takaros999 Takaros999 commented Jan 30, 2025 •
edited
Loading

PR Type

  • Regular Task
  • Bug Fix
  • QA Tests

Description

NOTE: The worker will only be activate in staging env until it's tested and ready for production.

This PR adds support for wld-username data deletion:

  • Adds data deletion worker working in the background. (processing is limited to 10 requests/minute, in the future we may increase this or move it to a separate instance)
  • Add data deletion request/completion queues
  • Refactors shutdown signal to support the server and the new worker

For context read:

Checklist

  • I have self-reviewed this PR.
  • I have left comments in the code for clarity.
  • I have added necessary unit tests.
  • I have updated the documentation as needed.

@Takaros999
Copy link
Contributor Author

Keeping this in Draft until I work some last-minute details with infra.

The core logic of the worker will remain the same, just waiting for confirmation for SQS connection, etc.

@Takaros999 Takaros999 marked this pull request as ready for review January 31, 2025 14:41
andy-t-wang
andy-t-wang reviewed Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@andy-t-wang andy-t-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow really well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-t-wang andy-t-wang andy-t-wang approved these changes

@michalstruck michalstruck Awaiting requested review from michalstruck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Takaros999 @andy-t-wang