Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm: address some findings #52

Open
wants to merge 2 commits into
base: evm/optimize
Choose a base branch
from
Open

evm: address some findings #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7ed9ec
evm: approve -> safeIncreaseAllowance
a5-pickle Apr 4, 2024
4c92c84
evm: remove Context
a5-pickle Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions evm/src/contracts/CircleIntegration/Setup.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
pragma solidity ^0.8.19;

import {ERC1967Upgrade} from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Upgrade.sol";
import {Context} from "@openzeppelin/contracts/utils/Context.sol";

contract Setup is ERC1967Upgrade, Context {
contract Setup is ERC1967Upgrade {
function setup(address implementation) public {
require(implementation != address(0), "invalid implementation");

Expand Down
2 changes: 1 addition & 1 deletion evm/src/contracts/WormholeCctpTokenMessenger.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ abstract contract WormholeCctpTokenMessenger {
* who will ultimately be burning the tokens.
*/
function setTokenMessengerApproval(address token, uint256 amount) internal {
IERC20(token).approve(address(_tokenMessenger), amount);
IERC20(token).safeIncreaseAllowance(address(_tokenMessenger), amount);
}

/**
Expand Down
Loading