terra: migrate to cosmwasm 1.1.0 #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcsongor
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
2 times, most recently
from
88ab475 to
aa03d41
Compare
|
If we go with option 1, do we risk more future breakages? |
evan-gray
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
from
ab88eb5 to
5e29b43
Compare
|
Any updates? It's still not fixed half a year since then. |
kcsongor
changed the title
kcsongor
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
from
3bd7c26 to
8d196f2
Compare
kcsongor
commented
Dec 6, 2023
kcsongor
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
2 times, most recently
from
7d2f893 to
410e793
Compare
kcsongor
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
2 times, most recently
from
922c159 to
4c7df7b
Compare
kcsongor
changed the title
kcsongor
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
2 times, most recently
from
4e1ce8f to
e689c73
Compare
evan-gray
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
from
e689c73 to
bbffe9c
Compare
kcsongor
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
from
af0da08 to
fd4068d
Compare
evan-gray
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
from
7f32f7f to
447eaef
Compare
kcsongor
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
from
447eaef to
7679f49
Compare
evan-gray
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
3 times, most recently
from
25aedba to
7b797f2
Compare
kcsongor
commented
Dec 10, 2023
kcsongor
commented
Dec 10, 2023
evan-gray
previously approved these changes
Dec 11, 2023
|
for those who'd like to re-review the recent force push, here's the diff https://github.com/wormhole-foundation/wormhole/compare/3567b59af39cf10606b744a57c54013041cf50ff..ckiss/fix-groundbreaking-terra-upgrade |
evan-gray
previously approved these changes
Dec 12, 2023
use `classic-bindings` crate instead of terra-cosmwasm. This is the updated version that calls the correct query post chain upgrade
Since the tests are now ran against the new LocalTerra which has burn tax, the transaction results are different from before
kcsongor
force-pushed
the
ckiss/fix-groundbreaking-terra-upgrade
branch
from
74286d2 to
7b321ca
Compare
evan-gray
approved these changes
Dec 12, 2023
a5-pickle
reviewed
Dec 13, 2023
a5-pickle
reviewed
Dec 13, 2023
a5-pickle
approved these changes
Dec 13, 2023
djb15
pushed a commit
to djb15/wormhole
that referenced
this pull request
Dec 14, 2023
* terra/contracts: migrate to cosmwasm 1.1.0 use `classic-bindings` crate instead of terra-cosmwasm. This is the updated version that calls the correct query post chain upgrade * terra/Dockerfile: update workspace optimizer * terra: label is now required on instantiate * terra: accept either 32 or 20 byte addresses * terra: update devnet terra classic * node/cosmwasm: always CW >1 * tilt: re-introduce terra classic tests * terra: make get_address support both 20 and 32 byte addresses * terra: fix tests to account for burn tax Since the tests are now ran against the new LocalTerra which has burn tax, the transaction results are different from before * terra/token-bridge: check first 12 bytes to determine native denoms * terra/token-bridge: simplify conditional --------- Co-authored-by: Evan Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terra classic upgraded to CosmWasm 1.0+ (https://classic-agora.terra.money/t/wasmvm-v0-16-6-v1-2-0/50070/73), which introduced a number of breaking changes across the whole ecosystem, ranging from tooling to smart contracts.
This PR upgrades the terra classic contracts to the new CosmWasm stdlib version, along with upgrades to the testing pipeline to support the new version. Some contract changes had to be made to accommodate the new 32 byte addressing scheme, these are documented in #3597.
Reviewing the PR
The PR is best reviewied commit-by-commit. The upgrade to CW1 necessitated vendoring the
cw20-legacylibrary. To keep things tidy, I forked it as a separate repo, the relevant commit is here wormhole-foundation/cw20-legacy@d127247.