Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCQ: Query SDK #3421

Merged
merged 2 commits into from
Oct 13, 2023
Merged

CCQ: Query SDK #3421

merged 2 commits into from
Oct 13, 2023

Conversation

bruce-riley
Copy link
Contributor

No description provided.

@bruce-riley bruce-riley changed the base branch from main to CCQ/Query_Server October 4, 2023 18:55
@bruce-riley bruce-riley mentioned this pull request Oct 4, 2023
Closed
@bruce-riley bruce-riley marked this pull request as ready for review October 4, 2023 21:55
@bruce-riley bruce-riley requested a review from evan-gray as a code owner October 4, 2023 21:55
@bruce-riley bruce-riley force-pushed the CCQ/Query_Server branch 3 times, most recently from c9337bc to 93b59cf Compare October 11, 2023 15:42
@evan-gray evan-gray mentioned this pull request Oct 12, 2023
Merged
@bruce-riley bruce-riley requested a review from barnjamin October 12, 2023 14:02
panoel
panoel previously approved these changes Oct 12, 2023
View reviewed changes
@bruce-riley bruce-riley force-pushed the CCQ/Query_Server branch 2 times, most recently from 301601c to b5d8ffe Compare October 12, 2023 18:25
Base automatically changed from CCQ/Query_Server to main October 12, 2023 19:29
@bruce-riley bruce-riley dismissed panoel’s stale review October 12, 2023 19:29

The base branch was changed.

@bruce-riley bruce-riley mentioned this pull request Oct 13, 2023
Merged
evan-gray
evan-gray approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think types might be missing from the package.json and we should add a note to the sdk folder readme (because it has a list of it's contents and now this will be missing) but feel free to make an issue from this.

@bruce-riley bruce-riley merged commit e060649 into main Oct 13, 2023
22 checks passed
@bruce-riley bruce-riley deleted the CCQ/Query_SDK branch October 13, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kev1n-peters kev1n-peters kev1n-peters approved these changes

@evan-gray evan-gray evan-gray approved these changes

@panoel panoel panoel approved these changes

@barnjamin barnjamin barnjamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bruce-riley @barnjamin @panoel @evan-gray @kev1n-peters