-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCQ: Query Server #3422
Merged
Merged
CCQ: Query Server #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
force-pushed
the
CCQ/node/Guardian_Changes
branch
from
October 4, 2023 18:53
ae39d94
to
24dbcdb
Compare
bruce-riley
force-pushed
the
CCQ/Query_Server
branch
from
October 4, 2023 19:59
16b9007
to
86a8f9f
Compare
bruce-riley
requested review from
panoel,
kev1n-peters and
evan-gray
as code owners
October 4, 2023 21:54
SEJeff
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of nits, but mainly I'm worried about productionizing the webserver and the p2p code that is public facing.
More unit tests for those components would be massively appreciated.
evan-gray
previously requested changes
Oct 7, 2023
bruce-riley
force-pushed
the
CCQ/node/Guardian_Changes
branch
from
October 10, 2023 20:00
24dbcdb
to
8445f0b
Compare
bruce-riley
force-pushed
the
CCQ/Query_Server
branch
2 times, most recently
from
October 10, 2023 23:14
6e07adc
to
5071a05
Compare
bruce-riley
force-pushed
the
CCQ/node/Guardian_Changes
branch
from
October 11, 2023 13:34
8445f0b
to
b78393e
Compare
bruce-riley
force-pushed
the
CCQ/Query_Server
branch
from
October 11, 2023 15:42
c9337bc
to
93b59cf
Compare
SEJeff
force-pushed
the
CCQ/Query_Server
branch
2 times, most recently
from
October 11, 2023 17:02
ec08acb
to
295376f
Compare
SEJeff
previously approved these changes
Oct 11, 2023
kev1n-peters
previously approved these changes
Oct 11, 2023
Merged
bruce-riley
force-pushed
the
CCQ/node/Guardian_Changes
branch
from
October 12, 2023 13:46
b78393e
to
13a1317
Compare
bruce-riley
force-pushed
the
CCQ/Query_Server
branch
from
October 12, 2023 16:16
295376f
to
301601c
Compare
bruce-riley
dismissed stale reviews from kev1n-peters and SEJeff
October 12, 2023 18:20
The base branch was changed.
bruce-riley
force-pushed
the
CCQ/Query_Server
branch
from
October 12, 2023 18:25
301601c
to
b5d8ffe
Compare
SEJeff
approved these changes
Oct 12, 2023
kev1n-peters
approved these changes
Oct 12, 2023
evan-gray
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CCQ (Cross Chain Query) REST server. This PR is dependent on PR #3423.
For background on this feature see the whitepaper (PR #3418).