Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCQ: Query Server #3422

Merged
merged 5 commits into from
Oct 12, 2023
Merged

CCQ: Query Server #3422

merged 5 commits into from
Oct 12, 2023

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Oct 4, 2023

This PR adds the CCQ (Cross Chain Query) REST server. This PR is dependent on PR #3423.

For background on this feature see the whitepaper (PR #3418).

@bruce-riley bruce-riley changed the base branch from main to CCQ/node/Guardian_Changes October 4, 2023 18:24
@bruce-riley bruce-riley force-pushed the CCQ/node/Guardian_Changes branch from ae39d94 to 24dbcdb Compare October 4, 2023 18:53
@bruce-riley bruce-riley requested a review from SEJeff October 4, 2023 19:08
@bruce-riley bruce-riley marked this pull request as ready for review October 4, 2023 21:54
Copy link
Collaborator

@SEJeff SEJeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of nits, but mainly I'm worried about productionizing the webserver and the p2p code that is public facing.

More unit tests for those components would be massively appreciated.

node/cmd/ccq/http.go Outdated Show resolved Hide resolved
node/cmd/ccq/http.go Show resolved Hide resolved
node/cmd/ccq/http.go Show resolved Hide resolved
node/cmd/ccq/http.go Outdated Show resolved Hide resolved
node/cmd/ccq/http.go Show resolved Hide resolved
node/cmd/ccq/utils.go Show resolved Hide resolved
node/cmd/ccq/utils.go Outdated Show resolved Hide resolved
node/cmd/ccq/utils.go Outdated Show resolved Hide resolved
node/cmd/ccq/utils.go Outdated Show resolved Hide resolved
node/cmd/ccq/utils.go Outdated Show resolved Hide resolved
node/cmd/ccq/utils.go Outdated Show resolved Hide resolved
@bruce-riley bruce-riley force-pushed the CCQ/node/Guardian_Changes branch from 24dbcdb to 8445f0b Compare October 10, 2023 20:00
@bruce-riley bruce-riley force-pushed the CCQ/Query_Server branch 2 times, most recently from 6e07adc to 5071a05 Compare October 10, 2023 23:14
@bruce-riley bruce-riley force-pushed the CCQ/node/Guardian_Changes branch from 8445f0b to b78393e Compare October 11, 2023 13:34
@SEJeff SEJeff force-pushed the CCQ/Query_Server branch 2 times, most recently from ec08acb to 295376f Compare October 11, 2023 17:02
SEJeff
SEJeff previously approved these changes Oct 11, 2023
kev1n-peters
kev1n-peters previously approved these changes Oct 11, 2023
@bruce-riley bruce-riley mentioned this pull request Oct 11, 2023
@SEJeff SEJeff dismissed evan-gray’s stale review October 11, 2023 20:21

Fixed by Bruce

@bruce-riley bruce-riley force-pushed the CCQ/node/Guardian_Changes branch from b78393e to 13a1317 Compare October 12, 2023 13:46
Base automatically changed from CCQ/node/Guardian_Changes to main October 12, 2023 18:20
@bruce-riley bruce-riley dismissed stale reviews from kev1n-peters and SEJeff October 12, 2023 18:20

The base branch was changed.

@evan-gray evan-gray self-requested a review October 12, 2023 18:38
@bruce-riley bruce-riley merged commit ad696d2 into main Oct 12, 2023
22 checks passed
@bruce-riley bruce-riley deleted the CCQ/Query_Server branch October 12, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants