CCQ/Node/EVM: Logger cleanup #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
requested review from
evan-gray,
panoel and
kev1n-peters
as code owners
panoel
approved these changes
Nov 16, 2023
bruce-riley
force-pushed
the
ccq/node/evm_logger_cleanup
branch
from
0fd00b1 to
76bdb3c
Compare
evan-gray
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a fairly big PR, but it is really quite simple. A previous PR added a separate
ccqLoggerto the watcher object to avoid having to constantly add the "ccqevm" component. This PR just changes the code to use that every where, rather passing the logger into all the CCQ functions.