CCQ: High level validation helpers + slight refactor #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-riley
reviewed
Nov 16, 2023
djb15
changed the title
djb15
requested review from
a5-pickle,
gator-boi and
kcsongor
as code owners
evan-gray
previously requested changes
Nov 21, 2023
SEJeff
previously approved these changes
Dec 3, 2023
|
@djb15 can you rebase this with the fixes to the tests you did that are in main please? |
gator-boi
requested changes
Dec 4, 2023
SEJeff
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed I've added some high level helpers that should hopefully make validating a parsed response easier for integrators rather than having to write validation logic from scratch every time.
I've also slightly refactored the passing of the wormhole address to avoid the potential for an integrator accidentally allowing the caller to specify this value.