Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wormchain: integration tests for wormchain-ibc-receiver #4155

Conversation

kakucodes
Copy link
Collaborator

@kakucodes kakucodes commented Nov 7, 2024

Add Integration Tests for IBC Contracts and CI Workflow

Overview

This PR implements comprehensive integration tests for wormchain-ibc-receiver and wormhole-ibc contracts using Interchain test framework, providing a realistic testing environment for IBC functionality. Additionally, it establishes automated CI testing through a new GitHub workflow.

Key Changes

  • Added integration tests using Interchain test framework to validate contract behavior
  • Implemented GitHub workflow to automatically run Interchaintest suite on pull requests

Technical Details

  • Tests run in a simulated multi-chain environment to verify IBC functionality
  • Contract interfaces are auto-generated from Rust contracts to Go
  • Automated channel creation and management through go-relayer
  • Full end-to-end testing of IBC packet transmission and handling
  • CI workflow ensures tests run automatically for every PR

Testing

Tests cover:

  • Channel establishment between chains
  • Packet transmission and acknowledgment
  • Contract state verification

Dependencies

  • Interchain test framework
  • go-codegen for interface generation
  • cosmos/relayer for IBC operations
  • GitHub Actions workflow configuration

Impact

These tests significantly improve our confidence in the IBC contracts by:

  • Validating behavior in a realistic environment
  • Ensuring proper integration between components
  • Automating previously manual testing processes
  • Preventing regressions through automated CI testing
  • Providing early detection of integration issues in the development cycle
  • The added GitHub workflow ensures that all future changes maintain the integrity of the codebase

@kakucodes kakucodes marked this pull request as ready for review November 21, 2024 17:20
@kakucodes kakucodes changed the title Feature/integration test ibc receiver wormchain: integration tests for wormchain-ibc-receiver Nov 21, 2024
joelsmith-2019
joelsmith-2019 previously approved these changes Nov 21, 2024
Copy link
Collaborator

@joelsmith-2019 joelsmith-2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marc and I spent time today walking through all of the code changes & tests. Everything looked good to me.

joelsmith-2019
joelsmith-2019 previously approved these changes Dec 10, 2024
nik-suri
nik-suri previously approved these changes Dec 10, 2024
Copy link
Contributor

@nik-suri nik-suri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified that the force push diffs do not modify any functionality since the last approvals.

Copy link
Collaborator

@djb15 djb15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@nik-suri nik-suri force-pushed the feature/integration-test-ibc-receiver branch from df9db20 to fad9810 Compare December 12, 2024 17:01
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed new workflow file

@kakucodes kakucodes merged commit 2306e2d into wormhole-foundation:main Dec 12, 2024
28 checks passed
@kakucodes kakucodes deleted the feature/integration-test-ibc-receiver branch December 12, 2024 18:17
kakucodes pushed a commit that referenced this pull request Dec 18, 2024
cosmwasm(cw_wormhole): integration tests- initial implementation

chore: adding additional vaa parsing tests

cosmwasm: added cw_wormhole integration tests and some code cleanup

cosmwasm: reverted contract changes

Update 0012_ibc_generic_messaging.md with permissionless channel creation information (#4167)

The `wormhole-ibc-receiver` contract contains an allowlist of Wormhole chain ID to channel mappings (other side of Cosmos chain). The allowlist is not used when receiving a packet because we don't want to handle the case of a token transfer failure on the other side. Instead, we just emit the message and ignore it in the IBC watcher. I am just updating the documentation to reflect this.

node: governor token list update

tilt: aptos multi-platform support

tilt: sui multi-platform support

tilt: node multi-platform support

tilt: solana-test-validator multi-platform support

tilt: smaller sui image

Add coin gecko pro API usage for the governor (#4025)

* Add coin gecko pro API usage for the governor

* Add in missing parameter for node test

* Fix missing parameter in publicrpcserver_test.go

* Add in NIT fixes

* Change CLI description

* Reorder error message so that the important part is not truncated in the logs

* Remove network test from unit test. Plan on creating a Github action cron action for this instead

* Remove unnecessary '&' from URL path

* Add in new parameters for gov from rebase

* Fix regression on query creation

* Add coin gecko pro API usage for the governor

* Add in NIT fixes

* Remove network test from unit test. Plan on creating a Github action cron action for this instead

---------

Co-authored-by: Maxwell Dulin <[email protected]>
Co-authored-by: Maxwell Dulin <[email protected]>

node: add amazon kms and benchmark signers (#4168)

* add kms and benchmark signers

* include context during guardiansigner calls

* add error counters and address review comment

* address pr comments

* address pr comments

---------

Co-authored-by: pleasew8t <[email protected]>

wormchain: add ibc_receiver_test and ict workflow (#4155)

Update CODEOWNERS (#4151)

sdk: worldchain mainnet SR entry. (#4188)

cosmwasm: refactored the to guardianAddress logic

wormchain: lower ict setup params to improve stability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants