-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wormchain: integration tests for wormchain-ibc-receiver #4155
wormchain: integration tests for wormchain-ibc-receiver #4155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marc and I spent time today walking through all of the code changes & tests. Everything looked good to me.
8d470fe
to
a1cb369
Compare
df9db20
a1cb369
to
df9db20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified that the force push diffs do not modify any functionality since the last approvals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
df9db20
to
fad9810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed new workflow file
cosmwasm(cw_wormhole): integration tests- initial implementation chore: adding additional vaa parsing tests cosmwasm: added cw_wormhole integration tests and some code cleanup cosmwasm: reverted contract changes Update 0012_ibc_generic_messaging.md with permissionless channel creation information (#4167) The `wormhole-ibc-receiver` contract contains an allowlist of Wormhole chain ID to channel mappings (other side of Cosmos chain). The allowlist is not used when receiving a packet because we don't want to handle the case of a token transfer failure on the other side. Instead, we just emit the message and ignore it in the IBC watcher. I am just updating the documentation to reflect this. node: governor token list update tilt: aptos multi-platform support tilt: sui multi-platform support tilt: node multi-platform support tilt: solana-test-validator multi-platform support tilt: smaller sui image Add coin gecko pro API usage for the governor (#4025) * Add coin gecko pro API usage for the governor * Add in missing parameter for node test * Fix missing parameter in publicrpcserver_test.go * Add in NIT fixes * Change CLI description * Reorder error message so that the important part is not truncated in the logs * Remove network test from unit test. Plan on creating a Github action cron action for this instead * Remove unnecessary '&' from URL path * Add in new parameters for gov from rebase * Fix regression on query creation * Add coin gecko pro API usage for the governor * Add in NIT fixes * Remove network test from unit test. Plan on creating a Github action cron action for this instead --------- Co-authored-by: Maxwell Dulin <[email protected]> Co-authored-by: Maxwell Dulin <[email protected]> node: add amazon kms and benchmark signers (#4168) * add kms and benchmark signers * include context during guardiansigner calls * add error counters and address review comment * address pr comments * address pr comments --------- Co-authored-by: pleasew8t <[email protected]> wormchain: add ibc_receiver_test and ict workflow (#4155) Update CODEOWNERS (#4151) sdk: worldchain mainnet SR entry. (#4188) cosmwasm: refactored the to guardianAddress logic wormchain: lower ict setup params to improve stability
Add Integration Tests for IBC Contracts and CI Workflow
Overview
This PR implements comprehensive integration tests for
wormchain-ibc-receiver
andwormhole-ibc
contracts using Interchain test framework, providing a realistic testing environment for IBC functionality. Additionally, it establishes automated CI testing through a new GitHub workflow.Key Changes
Technical Details
Testing
Tests cover:
Dependencies
Impact
These tests significantly improve our confidence in the IBC contracts by: