Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aptos: upgrade to 4.5.0 (toolchain + libs) #4174

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ali-bahjati
Copy link
Contributor

This PR is modeled on the last change that previously bumped to 3.1.0

This change bumps libraries and toolchain of Aptos to the Aptos CLI v4.5.0 version. The tests are slightly changed to accommodate the recent changes in the coin library that disallows coin operations on unitialized coins (this PR).

The PR is in draft state because aptos/Dockerfile requires a docker hash that I am unable to push myself so assuming this PR looks OK, and someone with permission can do that push, I can fix the PR as well and mark ready.

aptos/Dockerfile.base Outdated Show resolved Hide resolved
@ali-bahjati ali-bahjati marked this pull request as ready for review November 29, 2024 13:16
@evan-gray evan-gray force-pushed the aptos/upgrade-4.5.0 branch 2 times, most recently from 5b3df98 to 7cc83e1 Compare December 13, 2024 16:35
@evan-gray evan-gray requested a review from panoel as a code owner December 13, 2024 20:04
@evan-gray
Copy link
Contributor

evan-gray commented Dec 16, 2024

This PR is failing due to two issues.

  1. certain transactions during deploy and the NFT tests are failing on client.simulateTransaction. I added commits to bypass this, though I am unsure as to the root cause.
  2. aptosClient.getEventsByEventHandle is not returning the expected data, leading to errors like the following
    TypeError: Cannot read properties of undefined (reading 'data')
    const depositTokenId = event.data.id;

I am not familiar enough with the Aptos changes to immediately identify what needs to be changed here.

Next steps might be to compare https://explorer.aptoslabs.com/?network=local between main and this PR after a run of the tests. I was able to run tilt up -- --aptos --manual in the root followed by npm test -- aptos in sdk/js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants