tilt: more multi-platform support #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-gray
force-pushed
the
moar-m1
branch
2 times, most recently
from
ea61c0d to
85d5098
Compare
evan-gray
requested review from
bruce-riley,
SEJeff,
kev1n-peters,
kcsongor,
a5-pickle and
gator-boi
as code owners
kcsongor
approved these changes
Dec 11, 2024
bruce-riley
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the m1 flag in favor of the multi-platform
solana-test-validatorimage [src, image]. It also uses the newly rebuilt multi-image aptos and sui images and makes the guardian image compatible with an arm64 or amd64 build.With this PR, Near should now be the only container and test that fails on M-series Macs, which I tested via
tilt up -- --ci --num=2 --near=false.It is important to note that, when available, images should pin the index digest, which identifies the registry entry, not the manifext digest, which identifies a single platform image. See https://docs.docker.com/build/building/multi-platform/.
Reviewers: I wasn't able to build Sui from source with rust:1.62 but it appears to work with 1.79. Not sure if that would cause any other issues but it appears to work.