-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmwasm: update cw wormhole rust tests #4190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakucodes
force-pushed
the
chore/update-cw_wormhole-rust-tests
branch
from
December 13, 2024 15:46
755fe1d
to
9225a2e
Compare
cosmwasm: reverted contract changes
kakucodes
force-pushed
the
chore/update-cw_wormhole-rust-tests
branch
from
December 13, 2024 15:54
9225a2e
to
f9c880f
Compare
kakucodes
requested review from
nik-suri,
kcsongor and
a5-pickle
as code owners
December 13, 2024 16:44
joelsmith-2019
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over all code changes with Marc & everything's looking good.
nik-suri
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified that this change only affects non-functional testing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Integration Tests for CW Wormhole Contract
This PR introduces comprehensive integration tests for the CW Wormhole contract using cw-multi-test, with a focus on end-to-end testing of core functionality.
Key Changes
Implemented thorough integration tests for SubmitVAA logic covering:
Enhanced test infrastructure:
Testing Approach
The tests take a high-level integration approach, simulating the full application and contract interactions with accurate state representation and signature verification. This provides stronger guarantees about the contract's behavior in realistic scenarios compared to unit tests alone.
Next Steps
Once we upgrade to a newer version of cosmwasm-std (and therefore cw-multi-test), we can: