Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Update Celo watcher #4210

Conversation

bruce-riley
Copy link
Contributor

When Celo support was originally introduced to the watcher, they required a separate ABI, which was implemented as a separate connector. They are now migrating to an op-stack, which means they now support finalized and safe blocks. This also means we don't need the special connector. These changes are currently available in testnet. In mainnet, they currently support finalized but not safe. Once mainnet cuts over, Celo can be treated just like any other op-stack chain.

@bruce-riley bruce-riley force-pushed the node_update_celo_watcher branch 2 times, most recently from 3238153 to 68fe8a8 Compare January 7, 2025 16:21
@bruce-riley bruce-riley force-pushed the node_update_celo_watcher branch from 68fe8a8 to dce3a74 Compare January 7, 2025 16:23
@bruce-riley bruce-riley marked this pull request as ready for review January 7, 2025 16:27
node/Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@evan-gray evan-gray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so excited to be rid of --allow-multiple-definition! just a couple nits

@bruce-riley bruce-riley force-pushed the node_update_celo_watcher branch from 6ecdcf1 to 5b71789 Compare January 7, 2025 19:09
@bruce-riley bruce-riley requested a review from evan-gray January 7, 2025 19:10
evan-gray
evan-gray previously approved these changes Jan 7, 2025
@bruce-riley bruce-riley merged commit 56cf37a into wormhole-foundation:main Jan 7, 2025
28 checks passed
@bruce-riley bruce-riley deleted the node_update_celo_watcher branch January 7, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants