fixing dark mode bugs

wowwood · Jul 15, 2024 · e9e3cd6 · e9e3cd6
1 parent 503327a
commit e9e3cd6
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 10 deletions.
diff --git a/static/style.css b/static/style.css
@@ -271,11 +271,11 @@ body[data-page="--not-found--"] .govuk-header__container::before {
 }
 
 .col-wren {
-  color: var(--col-wren); /* meets WCAG AA */
+  color: var(--col-wren); /* meets WCAG AA (on light theme)*/
 }
 
 .col-wren--title {
-  color: #f47738; /* meets WCAG AA for LARGE TEXT ONLY*/
+  color: #f47738; /* meets WCAG AA for LARGE TEXT ONLY (on light theme)*/
 }
 
 .col-services {

diff --git a/templates/404.html b/templates/404.html
@@ -13,13 +13,11 @@ <h1 class="govuk-heading-xl govuk-!-margin-bottom-8">
     Page not found
   </h1>
   <p class="govuk-body">If you entered a web address, check it is correct.</p>
-  <p class="govuk-body">You can <a class="govuk-link" href="/">browse from the homepage</a> or use the search box above to find the information you need.</p>
-  <pre class="govuk-!-margin-top-8">Status code: 404</pre>
+  <p class="govuk-body">You can <a class="govuk-link--no-visited-state" href="/">browse from the homepage</a> or use the search box above to find the information you need.</p>
 </div>
 </div>
-<script>
-window.httpStatusCode = '404'
-</script>
+<span class="moj-badge moj-badge--grey moj-badge--large">Status code: 404</span>
+
 
     </main>
   </div>

diff --git a/templates/bloo-footer.html b/templates/bloo-footer.html
@@ -44,6 +44,9 @@ <h2 class="govuk-footer__heading govuk-heading-m">Single column list</h2>
 
     </div>
     <hr class="govuk-footer__section-break">
+
+    <button type="button" data-theme-toggle aria-label="Change to light theme" class="noto-emoji-bold govuk-button govuk-button--secondary">🌛</button>
+
     <div class="govuk-footer__meta">
       <div class="govuk-footer__meta-item govuk-footer__meta-item--grow">
 

diff --git a/templates/index.html b/templates/index.html
@@ -47,7 +47,7 @@ <h1 class="govuk-heading-xl header-index">Hi, I'm <span class="col-bloo">Blue</s
               <th scope="row" class="govuk-table__header">LinkedIn</th>
               <td class="govuk-table__cell"><i class="fa-brands fa-linkedin"></i></td>
               <td class="govuk-table__cell"><a href="https://linkedin.com/in/ww-uk" target="_blank"
-                  class="govuk-link govuk-link--no-visited-state">linkedin.com/in/ww-uk</a></td>
+                  class="govuk-link govuk-link--no-visited-state">in/ww-uk</a></td>
             </tr>
             <tr class="govuk-table__row">
               <th scope="row" class="govuk-table__header">Fediverse</th>
@@ -62,6 +62,13 @@ <h1 class="govuk-heading-xl header-index">Hi, I'm <span class="col-bloo">Blue</s
                   href="https://signal.me/#eu/MDqUW8HTRwTFBfvQ297i4tCbmlUkoemxxn3ZvSkTJARJEjc9Qz9IJ7sno5RgKyMB"
                   target="_blank" class="govuk-link govuk-link--no-visited-state">@blue.94</a></td>
             </tr>
+            <tr class="govuk-table__row">
+              <th scope="row" class="govuk-table__header">GitHub</th>
+              <td class="govuk-table__cell"><i class="fa-brands fa-github"></i></td>
+              <td class="govuk-table__cell"><a
+                  href="https://github.com/wowwood"
+                  target="_blank" class="govuk-link govuk-link--no-visited-state">@wowwood</a></td>
+            </tr>
           </tbody>
         </table>
 

diff --git a/templates/right-bar.html b/templates/right-bar.html
@@ -1,5 +1,3 @@
-<button type="button" data-theme-toggle aria-label="Change to light theme" class="noto-emoji-bold govuk-button govuk-button--secondary">🌛</button>
-
 <h3 class="govuk-heading-s col-services">Services:</h3>
 
 <span class="moj-badge moj-badge--green moj-badge--large">ONLINE</span>