Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ids as format for super admin list #60

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Add ids as format for super admin list #60

merged 3 commits into from
Feb 26, 2024

Conversation

ernilambar
Copy link
Member

Fixes #59

@ernilambar ernilambar requested a review from a team as a code owner February 26, 2024 05:37
@swissspidy
Copy link
Member

This lists usernames, not user IDs. What am I missing?

@ernilambar
Copy link
Member Author

This lists usernames, not user IDs. What am I missing?

Since we treat User ID, user email, or user login as User ID in our user commands, I assumed user_login could also be treated as ID and list as ids. Now I realise displaying actual IDs for ids would make more sense.

@ernilambar
Copy link
Member Author

@swissspidy PR is updated. Behat test is not triggered here also.

@swissspidy swissspidy closed this Feb 26, 2024
@swissspidy swissspidy reopened this Feb 26, 2024
@swissspidy swissspidy added this to the 2.0.14 milestone Feb 26, 2024
@swissspidy swissspidy merged commit 47a2eb3 into wp-cli:main Feb 26, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
command:super-admin-list
Projects
None yet
Milestone
2.0.14
Development

Successfully merging this pull request may close these issues.

Introduce ids as format for super-admin list
2 participants
@ernilambar @swissspidy