Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation string for Play Youtube Video button aria-label #122

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

audrasjb
Copy link
Contributor

Description

See this issue on WP-Rocket: wp-media/wp-rocket#7202
And the following PR: wp-media/wp-rocket#7203

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Chore
  • Release

Detailed scenario

See wp-media/wp-rocket#7203

Technical description

See wp-media/wp-rocket#7203

Documentation

See wp-media/wp-rocket#7203

New dependencies

None

Risks

None

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@audrasjb
Copy link
Contributor Author

My only concern is the gettext string text-domain.
I used the slug of this library as text-domain but this implies that any project using this library will have to change the related text-domain accordingly. I didn't find any other user facing string in this library.

Another option would be to replace the gettext translation string with a filter that could be used by other projects to replace the string with a gettext translation string.

What do you think?

Copy link
Contributor

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late here, Happy new year.
Just a small change request/question.

src/Assets.php Outdated Show resolved Hide resolved
@wordpressfan
Copy link
Contributor

Many thanks @audrasjb
I'm going to merge this and create another PR to fix svn in tests workflow then move forward from there.

@wordpressfan wordpressfan merged commit d0cb11a into wp-media:develop Jan 21, 2025
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Play Youtube Video" aria-label should be translatable
2 participants